You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Fedor Jutte (JIRA)" <ji...@apache.org> on 2010/03/29 18:37:27 UTC

[jira] Updated: (TEXEN-17) Default properties of Generator are processed differently than the propertie file(s) given in the Ant-task

     [ https://issues.apache.org/jira/browse/TEXEN-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fedor Jutte updated TEXEN-17:
-----------------------------

    Attachment: texen17-patch.txt

Attached patch that resolves this issue. 

The patch let's Generator.fillContextProperties() use TexenUtils.fillContextProperties(), and TexenUtils.fillContextProperties() supports creating objects from the properties. This patch also cleans up the TexenUtils.fillContextProperties() method to make it better readable.

> Default properties of Generator are processed differently than the propertie file(s) given in the Ant-task
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: TEXEN-17
>                 URL: https://issues.apache.org/jira/browse/TEXEN-17
>             Project: Texen
>          Issue Type: Bug
>    Affects Versions: 1.1
>            Reporter: Fedor Jutte
>             Fix For: 1.1
>
>         Attachments: texen17-patch.txt
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The TexenTask uses TexenUtils.populateContext() to populate the context.
> Instead of reusing TexenUtils.populateContext(), Generator.fillContextProperties() uses it's own, slightly different, algorithm to fill the context with it's default properties.
> Difference:
> TexenUtils.populateContext() provides additional support for entries like "license.file.contents = license.txt", but Generator.fillContextProperties() doesn't.
> Generator.fillContextProperties() provides additional supports for entries like "context.objects.strings=org.apache.velocity.util.StringUtils", but TexenUtils.populateContext() doesn't.
> SOLUTION:
> Instead of giving Generator.fillContextProperties() it's own algorithm, it should use TexenUtils.populateContext(). And the additional support for objects in Generator.fillContextProperties() should be added to TexenUtils.populateContext().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org