You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kathey Marsden (JIRA)" <ji...@apache.org> on 2007/02/12 23:51:05 UTC
[jira] Created: (DERBY-2324) convert StmtCloseFunTest to JUnit
convert StmtCloseFunTest to JUnit
---------------------------------
Key: DERBY-2324
URL: https://issues.apache.org/jira/browse/DERBY-2324
Project: Derby
Issue Type: Task
Components: Test
Affects Versions: 10.3.0.0
Reporter: Kathey Marsden
Assigned To: Kathey Marsden
Priority: Minor
Fix For: 10.3.0.0
Convert StmtCloseFunTest to JUnit to eliminate multiple masters
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2324) convert StmtCloseFunTest to JUnit
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-2324:
--------------------------------------
Attachment: remove.stat
remove.diff
remove.diff removes StmtCloseFunTest.
> convert StmtCloseFunTest to JUnit
> ---------------------------------
>
> Key: DERBY-2324
> URL: https://issues.apache.org/jira/browse/DERBY-2324
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Kathey Marsden
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: closedobjecttest.diff, closedobjecttest.stat, remove.diff, remove.stat
>
>
> Convert StmtCloseFunTest to JUnit to eliminate multiple masters
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-2324) convert StmtCloseFunTest to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden closed DERBY-2324.
---------------------------------
> convert StmtCloseFunTest to JUnit
> ---------------------------------
>
> Key: DERBY-2324
> URL: https://issues.apache.org/jira/browse/DERBY-2324
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Kathey Marsden
> Assigned To: Knut Anders Hatlen
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: closedobjecttest.diff, closedobjecttest.stat, remove.diff, remove.stat
>
>
> Convert StmtCloseFunTest to JUnit to eliminate multiple masters
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2324) convert StmtCloseFunTest to JUnit
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472550 ]
Knut Anders Hatlen commented on DERBY-2324:
-------------------------------------------
Just a FYI, I think most of what StmtCloseFunTest tests is covered by jdbc4.ClosedObjectTest.
> convert StmtCloseFunTest to JUnit
> ---------------------------------
>
> Key: DERBY-2324
> URL: https://issues.apache.org/jira/browse/DERBY-2324
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Kathey Marsden
> Assigned To: Kathey Marsden
> Priority: Minor
> Fix For: 10.3.0.0
>
>
> Convert StmtCloseFunTest to JUnit to eliminate multiple masters
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2324) convert StmtCloseFunTest to JUnit
Posted by "Daniel John Debrunner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474788 ]
Daniel John Debrunner commented on DERBY-2324:
----------------------------------------------
ClosedObjecttest fails on J2ME/CDC/Foundation since the incorrect suite is returned from the suite() method.
Will commit a fix soon.
> convert StmtCloseFunTest to JUnit
> ---------------------------------
>
> Key: DERBY-2324
> URL: https://issues.apache.org/jira/browse/DERBY-2324
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Kathey Marsden
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: closedobjecttest.diff, closedobjecttest.stat
>
>
> Convert StmtCloseFunTest to JUnit to eliminate multiple masters
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-2324) convert StmtCloseFunTest to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden reassigned DERBY-2324:
-------------------------------------
Assignee: (was: Kathey Marsden)
Unassigning myself from this issue since the test is run under the adapter.
> convert StmtCloseFunTest to JUnit
> ---------------------------------
>
> Key: DERBY-2324
> URL: https://issues.apache.org/jira/browse/DERBY-2324
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Kathey Marsden
> Priority: Minor
> Fix For: 10.3.0.0
>
>
> Convert StmtCloseFunTest to JUnit to eliminate multiple masters
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2324) convert StmtCloseFunTest to JUnit
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476006 ]
Myrna van Lunteren commented on DERBY-2324:
-------------------------------------------
I think this test can be removed, yes. StmtCloseFunTest is no longer in suites/derby* but it's running via jdbcapi/JDBCHarnessJavaTest.java...
> convert StmtCloseFunTest to JUnit
> ---------------------------------
>
> Key: DERBY-2324
> URL: https://issues.apache.org/jira/browse/DERBY-2324
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Kathey Marsden
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: closedobjecttest.diff, closedobjecttest.stat
>
>
> Convert StmtCloseFunTest to JUnit to eliminate multiple masters
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2324) convert StmtCloseFunTest to JUnit
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-2324:
--------------------------------------
Derby Info: (was: [Patch Available])
Committed closedobjecttest.diff to trunk with revision 510012.
> convert StmtCloseFunTest to JUnit
> ---------------------------------
>
> Key: DERBY-2324
> URL: https://issues.apache.org/jira/browse/DERBY-2324
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Kathey Marsden
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: closedobjecttest.diff, closedobjecttest.stat
>
>
> Convert StmtCloseFunTest to JUnit to eliminate multiple masters
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2324) convert StmtCloseFunTest to JUnit
Posted by "Daniel John Debrunner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474791 ]
Daniel John Debrunner commented on DERBY-2324:
----------------------------------------------
Committed revision 510140 to get the test running on J2ME.
> convert StmtCloseFunTest to JUnit
> ---------------------------------
>
> Key: DERBY-2324
> URL: https://issues.apache.org/jira/browse/DERBY-2324
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Kathey Marsden
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: closedobjecttest.diff, closedobjecttest.stat
>
>
> Convert StmtCloseFunTest to JUnit to eliminate multiple masters
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2324) convert StmtCloseFunTest to JUnit
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-2324:
--------------------------------------
Attachment: closedobjecttest.stat
closedobjecttest.diff
The attached patch (closedobjecttest.diff) moves ClosedObjectTest from the jdbc4 suite to jdbcapi and makes the necessary changes so that it runs under jdk1.4/jdk1.5 (and possibly JSR169, but I haven't tested it). Before this patch can be applied, you must run "svn rename java/testing/org/apache/derbyTesting/functionTests/tests/jdbc4/ClosedObjectTest.java java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/ClosedObjectTest.java".
> convert StmtCloseFunTest to JUnit
> ---------------------------------
>
> Key: DERBY-2324
> URL: https://issues.apache.org/jira/browse/DERBY-2324
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Kathey Marsden
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: closedobjecttest.diff, closedobjecttest.stat
>
>
> Convert StmtCloseFunTest to JUnit to eliminate multiple masters
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2324) convert StmtCloseFunTest to JUnit
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474935 ]
Knut Anders Hatlen commented on DERBY-2324:
-------------------------------------------
Thanks Dan for making it run under J2ME! (I was hoping you would if I could find a way to break it... ;)
Now that ClosedObjectTest runs on all supported JVMs, would it be OK to remove StmtCloseFunTest?
> convert StmtCloseFunTest to JUnit
> ---------------------------------
>
> Key: DERBY-2324
> URL: https://issues.apache.org/jira/browse/DERBY-2324
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Kathey Marsden
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: closedobjecttest.diff, closedobjecttest.stat
>
>
> Convert StmtCloseFunTest to JUnit to eliminate multiple masters
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2324) convert StmtCloseFunTest to JUnit
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-2324:
--------------------------------------
Derby Info: [Patch Available]
> convert StmtCloseFunTest to JUnit
> ---------------------------------
>
> Key: DERBY-2324
> URL: https://issues.apache.org/jira/browse/DERBY-2324
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Kathey Marsden
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: closedobjecttest.diff, closedobjecttest.stat
>
>
> Convert StmtCloseFunTest to JUnit to eliminate multiple masters
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (DERBY-2324) convert StmtCloseFunTest to JUnit
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren reopened DERBY-2324:
---------------------------------------
I don't think it's appropriate to close this issue referring to the jdbc4 test.
Looking at suites/AllPackages.java it appears this test currently only runs with jvms that support jdbc4 (i.e. jdk1.6 (and up, I assume)):
// Suites that are compiled using Java SE 6 target need to
// be added this way, otherwise creating the suite
// will throw an invalid class version error
if (JDBC.vmSupportsJDBC4())
{
suite.addTest(
addSuiteByReflection(
"org.apache.derbyTesting.functionTests.tests.jdbc4._Suite"));
}
Maybe ClosedObjectTest can be run with jdk14/jdk15...But just closing this is not ok, I think.
However, for priority/urgency of this JIRA task: the StmtCloseFunTest now runs under the JDBCHarnessAdapter...
> convert StmtCloseFunTest to JUnit
> ---------------------------------
>
> Key: DERBY-2324
> URL: https://issues.apache.org/jira/browse/DERBY-2324
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Kathey Marsden
> Assigned To: Kathey Marsden
> Priority: Minor
> Fix For: 10.3.0.0
>
>
> Convert StmtCloseFunTest to JUnit to eliminate multiple masters
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-2324) convert StmtCloseFunTest to JUnit
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen resolved DERBY-2324.
---------------------------------------
Resolution: Fixed
Assignee: Knut Anders Hatlen
Committed revision 512172.
> convert StmtCloseFunTest to JUnit
> ---------------------------------
>
> Key: DERBY-2324
> URL: https://issues.apache.org/jira/browse/DERBY-2324
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Kathey Marsden
> Assigned To: Knut Anders Hatlen
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: closedobjecttest.diff, closedobjecttest.stat, remove.diff, remove.stat
>
>
> Convert StmtCloseFunTest to JUnit to eliminate multiple masters
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-2324) convert StmtCloseFunTest to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden closed DERBY-2324.
---------------------------------
Resolution: Won't Fix
Since there is already Junit coverage for these cases, I won't convert this one.
> convert StmtCloseFunTest to JUnit
> ---------------------------------
>
> Key: DERBY-2324
> URL: https://issues.apache.org/jira/browse/DERBY-2324
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Kathey Marsden
> Assigned To: Kathey Marsden
> Priority: Minor
> Fix For: 10.3.0.0
>
>
> Convert StmtCloseFunTest to JUnit to eliminate multiple masters
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.