[GitHub] [sling-slingfeature-maven-plugin] cziegeler commented on a change in pull request #49: Replacement PR for #41 with a clean set of changes

[GitBox <gi...@apache.org>]

cziegeler commented on a change in pull request #49: Replacement PR for #41 with a clean set of changes
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/49#discussion_r386827555
 
 

 ##########
 File path: src/main/java/org/apache/sling/feature/maven/mojos/IncludeArtifactMojo.java
 ##########
 @@ -85,14 +129,28 @@ public void execute() throws MojoExecutionException, MojoFailureException {
             found = new Feature(new ArtifactId(this.project.getGroupId(), this.project.getArtifactId(),
                     this.project.getVersion(), includeArtifactClassifier, FeatureConstants.PACKAGING_FEATURE));
 
-            file = new File(this.getTmpDir(), "feature-" + this.includeArtifactClassifier + ".json");
+            file = new File(
+                this.getTmpDir(),
+                "feature" + (includeArtifactClassifier == null ? "" : "-" + includeArtifactClassifier) + ".json");
             key = file.getAbsolutePath();
             ProjectHelper.getFeatures(this.project).put(key, found);
             ProjectHelper.getAssembledFeatures(this.project).put(key, found);
         }
+        getLog().debug("Found Feature: " + found + ", artifact: " + art);
         includeArtifact(found, includeArtifactExtension, art);
+        getLog().debug("Feature Key: " + key + ", feature from key: " + ProjectHelper.getAssembledFeatures(this.project).get(key));
         includeArtifact(ProjectHelper.getAssembledFeatures(this.project).get(key), includeArtifactExtension,
                 art.copy(art.getId()));
+
+        addDependencies(found);
+
+        // Obtain any features from Source folder and add any Extensions to the target feature
 
 Review comment:
   I think this is not needed as you can do the aggregation separate

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services