[GitHub] [ozone] sodonnel commented on a change in pull request #3013: HDDS-6205. Add CLI command to display the latest Replication Manager report

[GitBox <gi...@apache.org>]

sodonnel commented on a change in pull request #3013:
URL: https://github.com/apache/ozone/pull/3013#discussion_r793074612



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java
##########
@@ -732,6 +733,12 @@ public boolean getReplicationManagerStatus() {
     return scm.getReplicationManager().isRunning();
   }
 
+  @Override
+  public ReplicationManagerReport getReplicationManagerReport() {
+    AUDIT.logWriteSuccess(buildAuditMessageForSuccess(
+        SCMAction.GET_REPLICATION_MANAGER_REPORT, null));
+    return scm.getReplicationManager().getContainerReport();
+  }

Review comment:
       I'm not sure. The information provided by the report is not sensitive - just a cluster health report and it is not resource intensive to produce it.
   
   Looking at the other operations in that same protocol server.
   
   start/stop replication manager are admin ops. Viewing its status is not an admin op.
   
   Start / stop balance is an admin op. Viewing its status is not.
   
   I am happy to make this one an admin op, but as it is read only and not performance intensive so I don't know if it needs to be.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org