You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <mo...@yahoo.in> on 2014/01/08 03:47:13 UTC
Review Request 16726: OOZIE-1581 Workflow performance optimizations
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16726/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1581
https://issues.apache.org/jira/browse/OOZIE-1581
Repository: oozie-git
Description
-------
See JIRA OOZIE-1581 and review request - https://reviews.apache.org/r/15225/diff/#16 for context. +1'ed there. Creating new review request against git repo.
Diffs
-----
core/src/main/java/org/apache/oozie/command/XCommand.java 0df49a4
core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 27e13ae
core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 2df3617
core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 61b2848
core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 137ea5a
core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java d8ef520
core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java fb85125
core/src/main/java/org/apache/oozie/service/WorkflowStoreService.java 6eecd9b
core/src/test/java/org/apache/oozie/TestDagEngine.java c4e132d
core/src/test/java/org/apache/oozie/action/TestActionFailover.java 85b5fbb
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java abaff9f
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionNotificationXCommand.java 59e3a49
core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 8b54a6c
core/src/test/java/org/apache/oozie/command/wf/TestNotificationXCommand.java 5bc9103
core/src/test/java/org/apache/oozie/command/wf/TestSignalXCommand.java dd1d559
core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 7637e16
core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 14b66c1
core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 627ab32
core/src/test/java/org/apache/oozie/test/XDataTestCase.java 422f00c
core/src/test/resources/wf-fork.xml 3d3113f
core/src/test/resources/wf-no-op.xml b53922c
examples/src/main/apps/cron/workflow.xml a5277d0
examples/src/main/apps/sla/workflow.xml d276666
Diff: https://reviews.apache.org/r/16726/diff/
Testing
-------
unit tests pass and stress tests done to test performance
Thanks,
Mona Chitnis
Re: Review Request 16726: OOZIE-1581 Workflow performance optimizations
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16726/#review31997
-----------------------------------------------------------
correcting earlier statement. Unit test failure in TestBundleStartXCommand is unrelated.
- Mona Chitnis
On Jan. 16, 2014, 2:54 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16726/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2014, 2:54 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1581
> https://issues.apache.org/jira/browse/OOZIE-1581
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> See JIRA OOZIE-1581 and review request - https://reviews.apache.org/r/15225/diff/#16 for context. +1'ed there. Creating new review request against git repo.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/XCommand.java 0df49a4
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 27e13ae
> core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 2df3617
> core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 61b2848
> core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 137ea5a
> core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java d8ef520
> core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java fb85125
> core/src/main/java/org/apache/oozie/service/WorkflowStoreService.java 6eecd9b
> core/src/test/java/org/apache/oozie/TestDagEngine.java c4e132d
> core/src/test/java/org/apache/oozie/action/TestActionFailover.java 85b5fbb
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java abaff9f
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionNotificationXCommand.java 59e3a49
> core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 8b54a6c
> core/src/test/java/org/apache/oozie/command/wf/TestNotificationXCommand.java 5bc9103
> core/src/test/java/org/apache/oozie/command/wf/TestSignalXCommand.java dd1d559
> core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 7637e16
> core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 14b66c1
> core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 627ab32
> core/src/test/java/org/apache/oozie/test/XDataTestCase.java 422f00c
> core/src/test/resources/wf-fork.xml 3d3113f
> core/src/test/resources/wf-no-op.xml b53922c
> examples/src/main/apps/cron/workflow.xml a5277d0
> examples/src/main/apps/sla/workflow.xml d276666
>
> Diff: https://reviews.apache.org/r/16726/diff/
>
>
> Testing
> -------
>
> unit tests pass and stress tests done to test performance
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 16726: OOZIE-1581 Workflow performance optimizations
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16726/#review32049
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On Jan. 16, 2014, 2:54 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16726/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2014, 2:54 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1581
> https://issues.apache.org/jira/browse/OOZIE-1581
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> See JIRA OOZIE-1581 and review request - https://reviews.apache.org/r/15225/diff/#16 for context. +1'ed there. Creating new review request against git repo.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/XCommand.java 0df49a4
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 27e13ae
> core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 2df3617
> core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 61b2848
> core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 137ea5a
> core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java d8ef520
> core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java fb85125
> core/src/main/java/org/apache/oozie/service/WorkflowStoreService.java 6eecd9b
> core/src/test/java/org/apache/oozie/TestDagEngine.java c4e132d
> core/src/test/java/org/apache/oozie/action/TestActionFailover.java 85b5fbb
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java abaff9f
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionNotificationXCommand.java 59e3a49
> core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 8b54a6c
> core/src/test/java/org/apache/oozie/command/wf/TestNotificationXCommand.java 5bc9103
> core/src/test/java/org/apache/oozie/command/wf/TestSignalXCommand.java dd1d559
> core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 7637e16
> core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 14b66c1
> core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 627ab32
> core/src/test/java/org/apache/oozie/test/XDataTestCase.java 422f00c
> core/src/test/resources/wf-fork.xml 3d3113f
> core/src/test/resources/wf-no-op.xml b53922c
> examples/src/main/apps/cron/workflow.xml a5277d0
> examples/src/main/apps/sla/workflow.xml d276666
>
> Diff: https://reviews.apache.org/r/16726/diff/
>
>
> Testing
> -------
>
> unit tests pass and stress tests done to test performance
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 16726: OOZIE-1581 Workflow performance optimizations
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16726/
-----------------------------------------------------------
(Updated Jan. 16, 2014, 2:54 a.m.)
Review request for oozie.
Bugs: OOZIE-1581
https://issues.apache.org/jira/browse/OOZIE-1581
Repository: oozie-git
Description
-------
See JIRA OOZIE-1581 and review request - https://reviews.apache.org/r/15225/diff/#16 for context. +1'ed there. Creating new review request against git repo.
Diffs
-----
core/src/main/java/org/apache/oozie/command/XCommand.java 0df49a4
core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 27e13ae
core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 2df3617
core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 61b2848
core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 137ea5a
core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java d8ef520
core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java fb85125
core/src/main/java/org/apache/oozie/service/WorkflowStoreService.java 6eecd9b
core/src/test/java/org/apache/oozie/TestDagEngine.java c4e132d
core/src/test/java/org/apache/oozie/action/TestActionFailover.java 85b5fbb
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java abaff9f
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionNotificationXCommand.java 59e3a49
core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 8b54a6c
core/src/test/java/org/apache/oozie/command/wf/TestNotificationXCommand.java 5bc9103
core/src/test/java/org/apache/oozie/command/wf/TestSignalXCommand.java dd1d559
core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 7637e16
core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 14b66c1
core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 627ab32
core/src/test/java/org/apache/oozie/test/XDataTestCase.java 422f00c
core/src/test/resources/wf-fork.xml 3d3113f
core/src/test/resources/wf-no-op.xml b53922c
examples/src/main/apps/cron/workflow.xml a5277d0
examples/src/main/apps/sla/workflow.xml d276666
Diff: https://reviews.apache.org/r/16726/diff/
Testing
-------
unit tests pass and stress tests done to test performance
Thanks,
Mona Chitnis
Re: Review Request 16726: OOZIE-1581 Workflow performance optimizations
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16726/
-----------------------------------------------------------
(Updated Jan. 16, 2014, 2:50 a.m.)
Review request for oozie.
Changes
-------
addressed review comment. ran unit tests again and they pass
Bugs: OOZIE-1581
https://issues.apache.org/jira/browse/OOZIE-1581
Repository: oozie-git
Description
-------
See JIRA OOZIE-1581 and review request - https://reviews.apache.org/r/15225/diff/#16 for context. +1'ed there. Creating new review request against git repo.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/XCommand.java 0df49a4
core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 27e13ae
core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 2df3617
core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 61b2848
core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 137ea5a
core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java d8ef520
core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java fb85125
core/src/main/java/org/apache/oozie/service/WorkflowStoreService.java 6eecd9b
core/src/test/java/org/apache/oozie/TestDagEngine.java c4e132d
core/src/test/java/org/apache/oozie/action/TestActionFailover.java 85b5fbb
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java abaff9f
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionNotificationXCommand.java 59e3a49
core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 8b54a6c
core/src/test/java/org/apache/oozie/command/wf/TestNotificationXCommand.java 5bc9103
core/src/test/java/org/apache/oozie/command/wf/TestSignalXCommand.java dd1d559
core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 7637e16
core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 14b66c1
core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 627ab32
core/src/test/java/org/apache/oozie/test/XDataTestCase.java 422f00c
core/src/test/resources/wf-fork.xml 3d3113f
core/src/test/resources/wf-no-op.xml b53922c
examples/src/main/apps/cron/workflow.xml a5277d0
examples/src/main/apps/sla/workflow.xml d276666
Diff: https://reviews.apache.org/r/16726/diff/
Testing
-------
unit tests pass and stress tests done to test performance
Thanks,
Mona Chitnis
Re: Review Request 16726: OOZIE-1581 Workflow performance optimizations
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16726/#review31917
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java
<https://reviews.apache.org/r/16726/#comment60713>
If and else if should be other way around.
if (if (wfJob.getStatus() != WorkflowJob.Status.RUNNING....) {
}
else if (syncAction != nul) {
}
- Rohini Palaniswamy
On Jan. 8, 2014, 2:47 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16726/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 2:47 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1581
> https://issues.apache.org/jira/browse/OOZIE-1581
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> See JIRA OOZIE-1581 and review request - https://reviews.apache.org/r/15225/diff/#16 for context. +1'ed there. Creating new review request against git repo.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/XCommand.java 0df49a4
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 27e13ae
> core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 2df3617
> core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 61b2848
> core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 137ea5a
> core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java d8ef520
> core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java fb85125
> core/src/main/java/org/apache/oozie/service/WorkflowStoreService.java 6eecd9b
> core/src/test/java/org/apache/oozie/TestDagEngine.java c4e132d
> core/src/test/java/org/apache/oozie/action/TestActionFailover.java 85b5fbb
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java abaff9f
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionNotificationXCommand.java 59e3a49
> core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 8b54a6c
> core/src/test/java/org/apache/oozie/command/wf/TestNotificationXCommand.java 5bc9103
> core/src/test/java/org/apache/oozie/command/wf/TestSignalXCommand.java dd1d559
> core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 7637e16
> core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 14b66c1
> core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 627ab32
> core/src/test/java/org/apache/oozie/test/XDataTestCase.java 422f00c
> core/src/test/resources/wf-fork.xml 3d3113f
> core/src/test/resources/wf-no-op.xml b53922c
> examples/src/main/apps/cron/workflow.xml a5277d0
> examples/src/main/apps/sla/workflow.xml d276666
>
> Diff: https://reviews.apache.org/r/16726/diff/
>
>
> Testing
> -------
>
> unit tests pass and stress tests done to test performance
>
>
> Thanks,
>
> Mona Chitnis
>
>