You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "vignesh-manel (via GitHub)" <gi...@apache.org> on 2023/08/13 18:48:34 UTC
[GitHub] [camel] vignesh-manel opened a new pull request, #11098: CAMEL-17318:WIP AWS Timestream component
vignesh-manel opened a new pull request, #11098:
URL: https://github.com/apache/camel/pull/11098
# Description
AWS Timestream Component WIP
# Target
- [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
- [x] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] vignesh-manel commented on pull request #11098: CAMEL-17318:WIP AWS Timestream component
Posted by "vignesh-manel (via GitHub)" <gi...@apache.org>.
vignesh-manel commented on PR #11098:
URL: https://github.com/apache/camel/pull/11098#issuecomment-1680916301
its working after making write and query extend abstract timestream endpoint, I will raise new PR, when I complete this, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] vignesh-manel closed pull request #11098: CAMEL-17318:WIP AWS Timestream component
Posted by "vignesh-manel (via GitHub)" <gi...@apache.org>.
vignesh-manel closed pull request #11098: CAMEL-17318:WIP AWS Timestream component
URL: https://github.com/apache/camel/pull/11098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11098: CAMEL-17318:WIP AWS Timestream component
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11098:
URL: https://github.com/apache/camel/pull/11098#issuecomment-1680787796
you need 2 components, 1 for each endpoint, you can have a base abstract class on the component if you want any shared code/logic (java inheritance).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] vignesh-manel commented on pull request #11098: CAMEL-17318:WIP AWS Timestream component
Posted by "vignesh-manel (via GitHub)" <gi...@apache.org>.
vignesh-manel commented on PR #11098:
URL: https://github.com/apache/camel/pull/11098#issuecomment-1680681633
@davsclaus sure, I will rebase and update the version, and also this is still WIP and will take few more days to complete, my main intention to raise this PR, was I am getting issue with 2 endpoints for same component, can you pls check test case logs that have failed and suggest solution for creating 2 endpoints(write and query) for the component?
[incremental-test.log](https://github.com/apache/camel/files/12360242/incremental-test.log)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #11098: CAMEL-17318:WIP AWS Timestream component
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11098:
URL: https://github.com/apache/camel/pull/11098#issuecomment-1676435053
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] vignesh-manel commented on pull request #11098: CAMEL-17318:WIP AWS Timestream component
Posted by "vignesh-manel (via GitHub)" <gi...@apache.org>.
vignesh-manel commented on PR #11098:
URL: https://github.com/apache/camel/pull/11098#issuecomment-1676435405
https://camel.zulipchat.com/#narrow/stream/364655-camel-v4-work-in-progress/topic/camel-aws2-timestream.20component/near/384562656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11098: CAMEL-17318:WIP AWS Timestream component
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11098:
URL: https://github.com/apache/camel/pull/11098#issuecomment-1680112992
At first quick glace this looks good - in the mean time we have released 4.0.0, so can you need to rebase and use 4.1.0-SNAPSHOT as the version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org