You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/22 06:27:14 UTC
[GitHub] HyukjinKwon edited a comment on issue #23797:
[WIP][SPARK-26856][PYSPARK] Python support for from_avro and to_avro APIs
HyukjinKwon edited a comment on issue #23797: [WIP][SPARK-26856][PYSPARK] Python support for from_avro and to_avro APIs
URL: https://github.com/apache/spark/pull/23797#issuecomment-466288012
Hmm , @gengliangwang, @cloud-fan and @viirya, do you maybe have an idea about how we include Avro function APIs in Python side? I think it's reasonable to include Python API since we have it in Java/Scala too.
The current way proposed in this PR looks a-okay to me for now (I am rethinking it again and again every time I see this PR) but wonder if you guys have another idea, for instance, providing this Python file separately somewhere .. (so that it can be used via `py-files`). However, for this way, we should provide a way to give this file to users in a .. somewhat elegant way.
BTW, I guess the current way is consistent with the existing way anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org