[GitHub] [kafka] cmccabe commented on a change in pull request #11634: MINOR: enable KRaft in TopicCommandIntegrationTest

[GitBox <gi...@apache.org>]

cmccabe commented on a change in pull request #11634:
URL: https://github.com/apache/kafka/pull/11634#discussion_r781655349



##########
File path: core/src/test/scala/unit/kafka/admin/TopicCommandIntegrationTest.scala
##########
@@ -443,25 +486,30 @@ class TopicCommandIntegrationTest extends KafkaServerTestHarness with Logging wi
     val deleteOffsetTopicOpts = new TopicCommandOptions(
       Array("--topic", Topic.GROUP_METADATA_TOPIC_NAME))
     val deleteOffsetTopicPath = DeleteTopicsTopicZNode.path(Topic.GROUP_METADATA_TOPIC_NAME)
-    assertFalse(zkClient.pathExists(deleteOffsetTopicPath), "Delete path for topic shouldn't exist before deletion.")
+    if (!isKRaftTest()) {
+      assertFalse(zkClient.pathExists(deleteOffsetTopicPath), "Delete path for topic shouldn't exist before deletion.")
+    }
     topicService.deleteTopic(deleteOffsetTopicOpts)
-    TestUtils.verifyTopicDeletion(zkClient, Topic.GROUP_METADATA_TOPIC_NAME, 1, servers)
+    TestUtils.waitForAllPartitionsMetadata(brokers, testTopicName, 0)

Review comment:
       good point, we should not change what we're waiting for here. fixed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org