You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2023/01/04 15:21:11 UTC
[GitHub] [netbeans] sdedic opened a new pull request, #5199: Fix #5196: use precise sha1 instead of deleted tag vm-20.3.0
sdedic opened a new pull request, #5199:
URL: https://github.com/apache/netbeans/pull/5199
It seems that `graalvm` project deleted the tag we'd relied on, so I've just replaced the tag name with the tag's sha1 commit id. Since it is not possible to `git clone` a specific commit, I've used an alternative technique to avoid full (big) clone -- see for example https://www.techiedelight.com/clone-git-repository-with-specific-revision/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a diff in pull request #5199: Fix #5196: use precise sha1 instead of deleted tag vm-20.3.0
Posted by GitBox <gi...@apache.org>.
sdedic commented on code in PR #5199:
URL: https://github.com/apache/netbeans/pull/5199#discussion_r1062321542
##########
java/java.mx.project/build.xml:
##########
@@ -26,15 +26,30 @@
<target name="-checkout-graalvm" unless="graal.dir.available">
<delete dir="${graal.dir}"/>
- <mkdir dir="${graal.dir}/.."/>
- <exec dir="${graal.dir}/.." executable="git" failonerror="true">
- <arg value="clone"/>
- <arg value="--depth=1"/>
- <arg value="--branch"/>
- <arg value="vm-20.3.0"/>
- <arg value="--single-branch"/>
+ <mkdir dir="${graal.dir}"/>
+
+ <!-- Avoid git-clone of the full Graal repository -->
+ <exec dir="${graal.dir}" executable="git" failonerror="true">
+ <arg value="init"/>
+ </exec>
+ <exec dir="${graal.dir}" executable="git" failonerror="true">
+ <arg value="remote"/>
+ <arg value="add"/>
+ <arg value="origin"/>
<arg value="https://github.com/oracle/graal"/>
</exec>
+ <echo message="Fetching GraalVM revision from https://github.com/oracle/graal"/>
+ <exec dir="${graal.dir}" executable="git" failonerror="true">
+ <arg value="fetch"/>
+ <arg value="origin"/>
+ <arg value="c5ff5a5a091bfd974640aaf6fbe51c81bd080438"/>
Review Comment:
Added in 232bcdc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5199: Fix #5196: use precise sha1 instead of deleted tag vm-20.3.0
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5199:
URL: https://github.com/apache/netbeans/pull/5199#issuecomment-1374399274
does this have to build graal from source? This is currently sidelining the CI cache, but graal src+bin would be also a bit too large to put into the cache so there is probably no way around it right now - just curious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jtulach commented on pull request #5199: Fix #5196: use precise sha1 instead of deleted tag vm-20.3.0
Posted by GitBox <gi...@apache.org>.
jtulach commented on PR #5199:
URL: https://github.com/apache/netbeans/pull/5199#issuecomment-1374391483
> It will be eventually better to upgrade to newer graal / mx sources.
That's certainly the idea! Yes, please move the testing to (at least) 22.3 version to make sure NetBeans/VSCode supports the latest GraalVM sources! CCing @MartinBalin
Btw. there shall be (and certainly used to be) a gate in GraalVM CI verifying that the latest stable version of NetBeans/IGV supports the latest GraalVM sources. As far as I know the gate was disabled in Dec 2021 when support for JDK8 was dropped. Consider re-establishing that gate, @sdedic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5199: Fix #5196: use precise sha1 instead of deleted tag vm-20.3.0
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #5199:
URL: https://github.com/apache/netbeans/pull/5199#discussion_r1061977749
##########
java/java.mx.project/build.xml:
##########
@@ -26,15 +26,30 @@
<target name="-checkout-graalvm" unless="graal.dir.available">
<delete dir="${graal.dir}"/>
- <mkdir dir="${graal.dir}/.."/>
- <exec dir="${graal.dir}/.." executable="git" failonerror="true">
- <arg value="clone"/>
- <arg value="--depth=1"/>
- <arg value="--branch"/>
- <arg value="vm-20.3.0"/>
- <arg value="--single-branch"/>
+ <mkdir dir="${graal.dir}"/>
+
+ <!-- Avoid git-clone of the full Graal repository -->
+ <exec dir="${graal.dir}" executable="git" failonerror="true">
+ <arg value="init"/>
+ </exec>
+ <exec dir="${graal.dir}" executable="git" failonerror="true">
+ <arg value="remote"/>
+ <arg value="add"/>
+ <arg value="origin"/>
<arg value="https://github.com/oracle/graal"/>
</exec>
+ <echo message="Fetching GraalVM revision from https://github.com/oracle/graal"/>
+ <exec dir="${graal.dir}" executable="git" failonerror="true">
+ <arg value="fetch"/>
+ <arg value="origin"/>
+ <arg value="c5ff5a5a091bfd974640aaf6fbe51c81bd080438"/>
Review Comment:
could be potentially useful to add a comment which states what version of graal that is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5199: Fix #5196: use precise sha1 instead of deleted tag vm-20.3.0
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5199:
URL: https://github.com/apache/netbeans/pull/5199#issuecomment-1372834898
lets get this in so that the tests can run again.
technically master would be red right now but the mx test step is ignored on master since it fails so often. It is only required to pass on PRs, as you can see on the conditional continue-on-error:
https://github.com/apache/netbeans/blob/9ea17f3470f002c589a8ecf216f25c65a40afab3/.github/workflows/main.yml#L714-L717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #5199: Fix #5196: use precise sha1 instead of deleted tag vm-20.3.0
Posted by GitBox <gi...@apache.org>.
mbien merged PR #5199:
URL: https://github.com/apache/netbeans/pull/5199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists