You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uniffle.apache.org by "advancedxy (via GitHub)" <gi...@apache.org> on 2023/02/06 03:45:23 UTC
[GitHub] [incubator-uniffle] advancedxy commented on issue #551: [Improvement][Style] add autolink to issues in PR title and commit msg
advancedxy commented on issue #551:
URL: https://github.com/apache/incubator-uniffle/issues/551#issuecomment-1418465944
> I would suggest omit issue id in the title, and just add it in the PR description.
>
> ```
> ### Why this change needed?
>
> Fix #123
> ```
>
The point to add issue id in the title is that we can links to issues and commits in Github's ecosystem. In most cases, only title is displayed for commits.
Another benefit to include issue id in PR title(included in commit title automatically) is the commit is also linked to the issue.
See https://github.com/apache/incubator-uniffle/issues/545 for example
<img width="993" alt="image" src="https://user-images.githubusercontent.com/807537/216879283-c4bdb453-46dd-422f-a5a3-75c95431671f.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org