You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "dd-willgan (via GitHub)" <gi...@apache.org> on 2023/05/04 03:11:04 UTC
[GitHub] [pinot] dd-willgan opened a new issue, #10719: Environment variables not substituted in configuration
dd-willgan opened a new issue, #10719:
URL: https://github.com/apache/pinot/issues/10719
The following config works
```
# pinot-broker.conf
pinot.broker.access.control.principals.admin.password=${env:ADMIN_PASSWORD}
```
but this one doesn't
```
# pinot-controller.conf
controller.segment.fetcher.auth.token=${env:AUTH_TOKEN}
```
The issue is in `PinotConfiguration` class, `String getProperty(String name)` calls `CompositeConfiguration.getStringArray` but `String getProperty(String name, String defaultValue)` calls `CompositeConfiguration.getProperty`. In `CompositeConfiguration` and other classes, `getStringArray`, `getString`, etc. interpolate environment variables but the generic `getProperty` doesn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] CA1087 commented on issue #10719: Environment variables not substituted in configuration
Posted by "CA1087 (via GitHub)" <gi...@apache.org>.
CA1087 commented on issue #10719:
URL: https://github.com/apache/pinot/issues/10719#issuecomment-1660434507
Is the fix for this released yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang closed issue #10719: Environment variables not substituted in configuration
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang closed issue #10719: Environment variables not substituted in configuration
URL: https://github.com/apache/pinot/issues/10719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #10719: Environment variables not substituted in configuration
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #10719:
URL: https://github.com/apache/pinot/issues/10719#issuecomment-1661201735
This is fixed with #10785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org