You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/05/08 17:19:06 UTC
[GitHub] eric-haibin-lin commented on a change in pull request #10847:
[MXNET-408] [WIP] inplace ReLU activation
eric-haibin-lin commented on a change in pull request #10847: [MXNET-408] [WIP] inplace ReLU activation
URL: https://github.com/apache/incubator-mxnet/pull/10847#discussion_r186802962
##########
File path: tests/python/gpu/test_operator_gpu.py
##########
@@ -1133,14 +1133,17 @@ def test_fullyconnected_with_type():
@with_seed()
def test_activation_with_type():
- sym = mx.sym.Activation(name='act', act_type='sigmoid')
- ctx_list = [{'ctx': mx.gpu(0), 'act_data': (2, 2, 10, 10), 'type_dict': {'act_data': np.float64}},
- {'ctx': mx.gpu(0), 'act_data': (2, 2, 10, 10), 'type_dict': {'act_data': np.float32}},
- {'ctx': mx.gpu(0), 'act_data': (2, 2, 10, 10), 'type_dict': {'act_data': np.float16}},
- {'ctx': mx.cpu(0), 'act_data': (2, 2, 10, 10), 'type_dict': {'act_data': np.float64}},
- {'ctx': mx.cpu(0), 'act_data': (2, 2, 10, 10), 'type_dict': {'act_data': np.float32}},
- {'ctx': mx.cpu(0), 'act_data': (2, 2, 10, 10), 'type_dict': {'act_data': np.float16}}]
- check_consistency(sym, ctx_list)
+ act_types = ['relu', 'sigmoid', 'tanh', 'softrelu', 'softsign']
+ shape = (2, 2, 10, 10)
+ for act_type in act_types:
+ sym = mx.sym.Activation(name='act', act_type=act_type)
+ ctx_list = [{'ctx': mx.gpu(0), 'act_data': shape, 'type_dict': {'act_data': np.float64}},
+ {'ctx': mx.gpu(0), 'act_data': shape, 'type_dict': {'act_data': np.float32}},
+ {'ctx': mx.gpu(0), 'act_data': shape, 'type_dict': {'act_data': np.float16}},
+ {'ctx': mx.cpu(0), 'act_data': shape, 'type_dict': {'act_data': np.float64}},
+ {'ctx': mx.cpu(0), 'act_data': shape, 'type_dict': {'act_data': np.float32}},
+ {'ctx': mx.cpu(0), 'act_data': shape, 'type_dict': {'act_data': np.float16}}]
+ check_consistency(sym, ctx_list)
Review comment:
Good point. I didn't know it doesn't check grad
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services