[GitHub] [logging-log4net] NicholasNoise commented on pull request #67: Fix CA2000, CA2237, CA3075

[GitBox <gi...@apache.org>]

NicholasNoise commented on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-694165275


   > 
   > 
   > That sounds like a good plan 👍
   
   Done!
   
   > I don't know enough about FxCop to be sure, but I'd expect that we could perhaps enable rule processing for a specific build configuration only -- and have that build configuration targeted by `npm test`, which can be run by CI (I have it running against my own appveyer, but haven't yet set it up for this official repository -- yet another Thing To Get Done).
   
   Two ruleset is the way to get things done (:
   
   > Don't be afraid of an external tool though -- it can always be made part of the build pipeline. That's not a bump for or against any particular tool -- just a note.
   
   Build-in tools are preferable, an external tool makes it harder for new contributor to join. But in the same time used tools should be effective by all means.
   I'm not familiar with SonarQube to make any conclusion so it is not up to me :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org