[GitHub] [pulsar] hangc0276 commented on a change in pull request #11596: Fix all web threads will get stuck when deleting the namespace

[GitBox <gi...@apache.org>]

hangc0276 commented on a change in pull request #11596:
URL: https://github.com/apache/pulsar/pull/11596#discussion_r684756197



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
##########
@@ -227,7 +227,8 @@ protected void internalDeleteNamespace(AsyncResponse asyncResponse, boolean auth
         boolean isEmpty;
         List<String> topics;
         try {
-            topics = pulsar().getNamespaceService().getListOfPersistentTopics(namespaceName).join();
+            topics = pulsar().getNamespaceService().getListOfPersistentTopics(namespaceName)

Review comment:
       nice catch!
   There are many places which call `getListOfPersistentTopics` also use `join` to get the CompletableFuture result, would you please fix them? thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org