You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/02/23 14:25:40 UTC
[GitHub] [hive] belugabehr opened a new pull request #2007: HIVE-24811: Extend Cached Dates to Other Areas
belugabehr opened a new pull request #2007:
URL: https://github.com/apache/hive/pull/2007
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on a change in pull request #2007: HIVE-24811: Extend Cached Dates to Other Areas
Posted by GitBox <gi...@apache.org>.
belugabehr commented on a change in pull request #2007:
URL: https://github.com/apache/hive/pull/2007#discussion_r581082406
##########
File path: common/src/java/org/apache/hadoop/hive/common/type/TimestampUtils.java
##########
@@ -176,7 +177,7 @@ public static Timestamp stringToTimestamp(String s) {
// Handle simpler cases directly avoiding exceptions
if (s.length() == DATE_LENGTH) {
// Its a date!
- return Timestamp.ofEpochMilli(Date.valueOf(s).toEpochMilli());
+ return Timestamp.ofEpochMilli(DateParser.parseDate(s).toEpochMilli());
Review comment:
So, this one is a little weird. Previously, `Date.valueOf` could potentially throw an `IllegalArgumentException` if the string was invalid, contrary to the comment:
> Handle simpler cases directly avoiding exceptions
Now, it could throw a NPE as DateParser returns `null` on invalid input.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr merged pull request #2007: HIVE-24811: Extend Cached Dates to Other Areas
Posted by GitBox <gi...@apache.org>.
belugabehr merged pull request #2007:
URL: https://github.com/apache/hive/pull/2007
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on a change in pull request #2007: HIVE-24811: Extend Cached Dates to Other Areas
Posted by GitBox <gi...@apache.org>.
belugabehr commented on a change in pull request #2007:
URL: https://github.com/apache/hive/pull/2007#discussion_r582352865
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java
##########
@@ -110,17 +111,18 @@ private Date convertToDate(PrimitiveCategory inputType, Converter converter, Def
switch (inputType) {
case STRING:
case VARCHAR:
- case CHAR:
+ case CHAR: {
Review comment:
`Timestamp ts` is declared twice: in CHAR and TIMESTAMP. Needs the block or won't compile for having two variables with same name,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on a change in pull request #2007: HIVE-24811: Extend Cached Dates to Other Areas
Posted by GitBox <gi...@apache.org>.
belugabehr commented on a change in pull request #2007:
URL: https://github.com/apache/hive/pull/2007#discussion_r581086539
##########
File path: serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
##########
@@ -1124,33 +1125,25 @@ public static Date getDate(Object o, PrimitiveObjectInspector oi) {
case STRING:
StringObjectInspector soi = (StringObjectInspector) oi;
String s = soi.getPrimitiveJavaObject(o).trim();
- try {
- if (s.length() == DATE_LENGTH) {
- result = Date.valueOf(s);
- } else {
- Timestamp ts = getTimestampFromString(s);
- if (ts != null) {
- result = Date.ofEpochMilli(ts.toEpochMilli());
- }
+ if (s.length() == DATE_LENGTH) {
+ result = DateParser.parseDate(s);
+ } else {
+ Timestamp ts = getTimestampFromString(s);
+ if (ts != null) {
+ result = Date.ofEpochMilli(ts.toEpochMilli());
}
- } catch (IllegalArgumentException e) {
- // Do nothing
Review comment:
The net effect here for `Do nothing` is to return a `null` value. `DateParser#parseDate` returns a `null` value instead of an Exception, so can remove this confusing try/catch block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr closed pull request #2007: HIVE-24811: Extend Cached Dates to Other Areas
Posted by GitBox <gi...@apache.org>.
belugabehr closed pull request #2007:
URL: https://github.com/apache/hive/pull/2007
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] miklosgergely commented on a change in pull request #2007: HIVE-24811: Extend Cached Dates to Other Areas
Posted by GitBox <gi...@apache.org>.
miklosgergely commented on a change in pull request #2007:
URL: https://github.com/apache/hive/pull/2007#discussion_r582340030
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java
##########
@@ -110,17 +111,18 @@ private Date convertToDate(PrimitiveCategory inputType, Converter converter, Def
switch (inputType) {
case STRING:
case VARCHAR:
- case CHAR:
+ case CHAR: {
Review comment:
Why the barces? We don't use them anywhere else, no need for them, in a switch the code after a case is a block by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on a change in pull request #2007: HIVE-24811: Extend Cached Dates to Other Areas
Posted by GitBox <gi...@apache.org>.
belugabehr commented on a change in pull request #2007:
URL: https://github.com/apache/hive/pull/2007#discussion_r582015838
##########
File path: common/src/java/org/apache/hadoop/hive/common/type/TimestampUtils.java
##########
@@ -176,7 +177,7 @@ public static Timestamp stringToTimestamp(String s) {
// Handle simpler cases directly avoiding exceptions
if (s.length() == DATE_LENGTH) {
// Its a date!
- return Timestamp.ofEpochMilli(Date.valueOf(s).toEpochMilli());
+ return Timestamp.ofEpochMilli(DateParser.parseDate(s).toEpochMilli());
Review comment:
OK, based on a failed unit test, it does actually throw an `IllegalArugmentException` here despite the comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org