[jira] Commented: (OFBIZ-81) Support for PaymentMethod.description

["Chris Howe (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/OFBIZ-81?page=comments#action_12419760 ] 

Chris Howe commented on OFBIZ-81:
---------------------------------

I'm going to again object to this approach.  Not because this particular implementation is foreseeably too constraining, but rather because less than stellar design becomes precedent for future less than stellar design (ie "there's already examples of doing it this way").

I have three objections to this approach from a design point of view.

1) "Joe's Credit Card" is an alias for the Credit Card - not the payment method;  "Our Main Checking Account" is an alias for the checking account - not the payment method.

2) "Joe's Credit Card" and "Our Main Checking Account" are aliases that do not have a one to one relationship with their control.

3)  A data model should not be designed around the code that is manipulating it.  Rather, the code should be modified around the data model.

I have no objection to creating a PaymentMethod.description as a denormalized field that is supported as a denormalized field (ie.  a service populates PaymentMethod.description to CreditCardAttribut.attributeValue when CreditCardAtribute.attributeType="PRIMARY_ALIAS" changes)

> Support for PaymentMethod.description
> -------------------------------------
>
>          Key: OFBIZ-81
>          URL: http://issues.apache.org/jira/browse/OFBIZ-81
>      Project: The Open For Business Project
>         Type: New Feature

>   Components: accounting
>     Reporter: Si Chen
>     Priority: Minor

>
> Add additional field "description" to PaymentMethod to describe the payment method (ie, "Joe's credit card" or "Our main checking account")
> Add support for this field in the create, update, and view payment method services.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira