You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Bhushan Mandhani (JIRA)" <ji...@apache.org> on 2012/06/12 01:04:43 UTC
[jira] [Created] (HIVE-3114) Split Thrift interface for Table Link
Creation
Bhushan Mandhani created HIVE-3114:
--------------------------------------
Summary: Split Thrift interface for Table Link Creation
Key: HIVE-3114
URL: https://issues.apache.org/jira/browse/HIVE-3114
Project: Hive
Issue Type: New Feature
Affects Versions: 0.10.0
Reporter: Bhushan Mandhani
Assignee: Bhushan Mandhani
Priority: Minor
Table Link creation through Thrift currently goes through the same method as Table creation. We want to move it out of there and into it's own method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3114) Split Thrift interface for Table
Link Creation
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293243#comment-13293243 ]
Carl Steinbach commented on HIVE-3114:
--------------------------------------
bq. I dont think so - there are many features (views/indexes etc.) which have been around for a long time without a thrift interface.
That's true, and it was mistake to do it that way. Instead of continuing to compound the effects of an earlier bad decision can we please instead invest a little extra time and actually make the situation better?
Also, this is the sort of thing that should have been described up front in the design document. Since the List Bucketing feature requires similar changes I'd like to see any metastore API changes that the feature requires explained in the design doc before they appear in a patch.
> Split Thrift interface for Table Link Creation
> ----------------------------------------------
>
> Key: HIVE-3114
> URL: https://issues.apache.org/jira/browse/HIVE-3114
> Project: Hive
> Issue Type: New Feature
> Affects Versions: 0.10.0
> Reporter: Bhushan Mandhani
> Assignee: Bhushan Mandhani
> Priority: Minor
>
> Table Link creation through Thrift currently goes through the same method as Table creation. We want to move it out of there and into it's own method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3114) Split Thrift interface for Table
Link Creation
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293237#comment-13293237 ]
Namit Jain commented on HIVE-3114:
----------------------------------
I dont think so - there are many features (views/indexes etc.) which have been around for a long time without a thrift interface.
Given the fact that there is a validity check and existing thrift APIs cannot create invalid objects (barring bugs in the validity check),
HIVE-3114 should not be a pre-req. for HIVE-2989.
> Split Thrift interface for Table Link Creation
> ----------------------------------------------
>
> Key: HIVE-3114
> URL: https://issues.apache.org/jira/browse/HIVE-3114
> Project: Hive
> Issue Type: New Feature
> Affects Versions: 0.10.0
> Reporter: Bhushan Mandhani
> Assignee: Bhushan Mandhani
> Priority: Minor
>
> Table Link creation through Thrift currently goes through the same method as Table creation. We want to move it out of there and into it's own method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3114) Split Thrift interface for Table
Link Creation
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293198#comment-13293198 ]
Carl Steinbach commented on HIVE-3114:
--------------------------------------
@Bhushan: What's the timeline for doing this? I'm concerned that the Metastore Thrift interface is one of Hive's de facto public APIs, and any new functionality that appears in a release will need to be supported going forward. Why not just fix this in HIVE-2989 and eliminate the possibility that we're going to get stuck with an interface that we already know is broken?
> Split Thrift interface for Table Link Creation
> ----------------------------------------------
>
> Key: HIVE-3114
> URL: https://issues.apache.org/jira/browse/HIVE-3114
> Project: Hive
> Issue Type: New Feature
> Affects Versions: 0.10.0
> Reporter: Bhushan Mandhani
> Assignee: Bhushan Mandhani
> Priority: Minor
>
> Table Link creation through Thrift currently goes through the same method as Table creation. We want to move it out of there and into it's own method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3114) Split Thrift interface for Table
Link Creation
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293250#comment-13293250 ]
Namit Jain commented on HIVE-3114:
----------------------------------
@Carl, I agree the comment on list bucketing. Please address it in the wiki, we should definitely take that into account.
Agreed it was a mistake for unclean thrift API. But, we cannot penalize a single feature, which we need urgently, for that.
I am all for the thrift cleanup - it is just that the timing is not right from our side. I would be happy to help in any way if someone
else takes the thrift API cleanup effort.
@Bhushan, in the links wiki - can you add a follow-up for the thrift interface ?
Or, just add a link to all the follow-up jiras there.
> Split Thrift interface for Table Link Creation
> ----------------------------------------------
>
> Key: HIVE-3114
> URL: https://issues.apache.org/jira/browse/HIVE-3114
> Project: Hive
> Issue Type: New Feature
> Affects Versions: 0.10.0
> Reporter: Bhushan Mandhani
> Assignee: Bhushan Mandhani
> Priority: Minor
>
> Table Link creation through Thrift currently goes through the same method as Table creation. We want to move it out of there and into it's own method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3114) Split Thrift interface for Table
Link Creation
Posted by "Bhushan Mandhani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293283#comment-13293283 ]
Bhushan Mandhani commented on HIVE-3114:
----------------------------------------
@Carl When were we planning to release 0.10.0? I can definitely commit to finishing this particular Jira in time for it. I cannot commit to finishing all followups in time. Having said that, I and Sambavi are both actively working on Links and we should knock these out in the near future. We are keen to commit this patch soon because it is hard for us to have multiple people work in parallel on Links unless this base patch goes in. This patch is what everything else will build on top of.
> Split Thrift interface for Table Link Creation
> ----------------------------------------------
>
> Key: HIVE-3114
> URL: https://issues.apache.org/jira/browse/HIVE-3114
> Project: Hive
> Issue Type: New Feature
> Affects Versions: 0.10.0
> Reporter: Bhushan Mandhani
> Assignee: Bhushan Mandhani
> Priority: Minor
>
> Table Link creation through Thrift currently goes through the same method as Table creation. We want to move it out of there and into it's own method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3114) Split Thrift interface for Table
Link Creation
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293261#comment-13293261 ]
Carl Steinbach commented on HIVE-3114:
--------------------------------------
bq. Agreed it was a mistake for unclean thrift API. But, we cannot penalize a single feature, which we need urgently, for that.
I am all for the thrift cleanup - it is just that the timing is not right from our side.
I'm not asking you to clean up the entire metastore Thrift API. All I'm asking is for you to add a createTableLink() method instead of overloading the createTable() method. It's fine if both createTable() and createTableLink() use a common codepath behind the Thrift API, but the Thrift API needs to call these things out as distinct operations.
bq. @Bhushan, in the links wiki - can you add a follow-up for the thrift interface ?
When are these followups going to be addressed? If they aren't committed in time for the 0.10.0 release are you OK with us backing out these changes?
> Split Thrift interface for Table Link Creation
> ----------------------------------------------
>
> Key: HIVE-3114
> URL: https://issues.apache.org/jira/browse/HIVE-3114
> Project: Hive
> Issue Type: New Feature
> Affects Versions: 0.10.0
> Reporter: Bhushan Mandhani
> Assignee: Bhushan Mandhani
> Priority: Minor
>
> Table Link creation through Thrift currently goes through the same method as Table creation. We want to move it out of there and into it's own method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3114) Split Thrift interface for Table
Link Creation
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293264#comment-13293264 ]
Namit Jain commented on HIVE-3114:
----------------------------------
Absolutely not, a feature may not be ready for 0.10.
That does not mean that the code for that feature will be deleted.
If 'links' is not available in 0.10, let us document it clearly - when all the jiras are ready, 'links' will be available in that release.
> Split Thrift interface for Table Link Creation
> ----------------------------------------------
>
> Key: HIVE-3114
> URL: https://issues.apache.org/jira/browse/HIVE-3114
> Project: Hive
> Issue Type: New Feature
> Affects Versions: 0.10.0
> Reporter: Bhushan Mandhani
> Assignee: Bhushan Mandhani
> Priority: Minor
>
> Table Link creation through Thrift currently goes through the same method as Table creation. We want to move it out of there and into it's own method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3114) Split Thrift interface for Table
Link Creation
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293743#comment-13293743 ]
Namit Jain commented on HIVE-3114:
----------------------------------
There is a validateTable added as part of HIVE-2989. It would be good to add negative tests as part of this patch, where the errors are thrown due to bad parameters.
> Split Thrift interface for Table Link Creation
> ----------------------------------------------
>
> Key: HIVE-3114
> URL: https://issues.apache.org/jira/browse/HIVE-3114
> Project: Hive
> Issue Type: New Feature
> Affects Versions: 0.10.0
> Reporter: Bhushan Mandhani
> Assignee: Bhushan Mandhani
> Priority: Minor
>
> Table Link creation through Thrift currently goes through the same method as Table creation. We want to move it out of there and into it's own method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (HIVE-3114) Split Thrift interface for
Table Link Creation
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293261#comment-13293261 ]
Carl Steinbach edited comment on HIVE-3114 at 6/12/12 1:37 AM:
---------------------------------------------------------------
bq. Agreed it was a mistake for unclean thrift API. But, we cannot penalize a single feature, which we need urgently, for that. I am all for the thrift cleanup - it is just that the timing is not right from our side.
I'm not asking you to clean up the entire metastore Thrift API. All I'm asking is for you to add a createTableLink() method instead of overloading the createTable() method. It's fine if both createTable() and createTableLink() use a common codepath behind the Thrift API, but the Thrift API needs to call these things out as distinct operations.
bq. @Bhushan, in the links wiki - can you add a follow-up for the thrift interface ?
When are these followups going to be addressed? If they aren't committed in time for the 0.10.0 release are you OK with us backing out these changes?
was (Author: cwsteinbach):
bq. Agreed it was a mistake for unclean thrift API. But, we cannot penalize a single feature, which we need urgently, for that.
I am all for the thrift cleanup - it is just that the timing is not right from our side.
I'm not asking you to clean up the entire metastore Thrift API. All I'm asking is for you to add a createTableLink() method instead of overloading the createTable() method. It's fine if both createTable() and createTableLink() use a common codepath behind the Thrift API, but the Thrift API needs to call these things out as distinct operations.
bq. @Bhushan, in the links wiki - can you add a follow-up for the thrift interface ?
When are these followups going to be addressed? If they aren't committed in time for the 0.10.0 release are you OK with us backing out these changes?
> Split Thrift interface for Table Link Creation
> ----------------------------------------------
>
> Key: HIVE-3114
> URL: https://issues.apache.org/jira/browse/HIVE-3114
> Project: Hive
> Issue Type: New Feature
> Affects Versions: 0.10.0
> Reporter: Bhushan Mandhani
> Assignee: Bhushan Mandhani
> Priority: Minor
>
> Table Link creation through Thrift currently goes through the same method as Table creation. We want to move it out of there and into it's own method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira