You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/07/19 17:40:16 UTC
[GitHub] [brooklyn-server] algairim opened a new pull request #1208: Support logbook multi-phrase query
algairim opened a new pull request #1208:
URL: https://github.com/apache/brooklyn-server/pull/1208
Signed-off-by: Mykola Mandra <my...@cloudsoft.io>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] jcabrerizo merged pull request #1208: Support logbook multi-phrase query
Posted by GitBox <gi...@apache.org>.
jcabrerizo merged pull request #1208:
URL: https://github.com/apache/brooklyn-server/pull/1208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] jcabrerizo commented on a change in pull request #1208: Support logbook multi-phrase query
Posted by GitBox <gi...@apache.org>.
jcabrerizo commented on a change in pull request #1208:
URL: https://github.com/apache/brooklyn-server/pull/1208#discussion_r673807082
##########
File path: core/src/main/java/org/apache/brooklyn/util/core/logbook/file/FileLogStore.java
##########
@@ -200,4 +201,15 @@ protected BrooklynLogEntry parseLogLine(String logLine, AtomicInteger lineCount)
}
return entry;
}
+
+ public static boolean containsSearchPhrases(String logMessage, List<String> searchPhrases) {
+ boolean found = true;
+ for (String searchPhrase : searchPhrases) {
+ if (!logMessage.contains(searchPhrase)) {
+ found = false;
Review comment:
May returning here `false` makes the code more readable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org