You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "ruanwenjun (via GitHub)" <gi...@apache.org> on 2024/01/16 14:26:32 UTC
[PR] Use DefaultUncaughtExceptionHandler to log the uncached exception [dolphinscheduler]
ruanwenjun opened a new pull request, #15496:
URL: https://github.com/apache/dolphinscheduler/pull/15496
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
## Purpose of the pull request
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use DefaultUncaughtExceptionHandler to log the uncached exception [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15496:
URL: https://github.com/apache/dolphinscheduler/pull/15496#issuecomment-1894986601
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496) **Quality Gate failed**
Failed conditions
[40.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15496&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use DefaultUncaughtExceptionHandler to log the uncached exception [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15496:
URL: https://github.com/apache/dolphinscheduler/pull/15496#issuecomment-1895853290
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496) **Quality Gate failed**
Failed conditions
[40.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15496&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use DefaultUncaughtExceptionHandler to log the uncached exception [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15496:
URL: https://github.com/apache/dolphinscheduler/pull/15496#issuecomment-1894828923
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496) **Quality Gate failed**
Failed conditions
[40.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15496&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use DefaultUncaughtExceptionHandler to log the uncached exception [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15496:
URL: https://github.com/apache/dolphinscheduler/pull/15496#issuecomment-1893907100
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496) **Quality Gate failed**
Failed conditions
[40.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15496&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use DefaultUncaughtExceptionHandler to log the uncached exception [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15496:
URL: https://github.com/apache/dolphinscheduler/pull/15496#issuecomment-1893904207
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496) **Quality Gate failed**
Failed conditions
[40.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15496&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use DefaultUncaughtExceptionHandler to log the uncached exception [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15496:
URL: https://github.com/apache/dolphinscheduler/pull/15496#issuecomment-1895933513
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496) **Quality Gate failed**
Failed conditions
[40.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15496&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use DefaultUncaughtExceptionHandler to log the uncached exception [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15496:
URL: https://github.com/apache/dolphinscheduler/pull/15496#issuecomment-1894829231
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496) **Quality Gate failed**
Failed conditions
[40.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15496&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use DefaultUncaughtExceptionHandler to log the uncached exception [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15496:
URL: https://github.com/apache/dolphinscheduler/pull/15496#issuecomment-1897724166
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496) **Quality Gate failed**
Failed conditions
[40.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15496&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use DefaultUncaughtExceptionHandler to log the uncached exception [dolphinscheduler]
Posted by "fuchanghai (via GitHub)" <gi...@apache.org>.
fuchanghai commented on code in PR #15496:
URL: https://github.com/apache/dolphinscheduler/pull/15496#discussion_r1454614663
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/metrics/WorkerServerMetrics.java:
##########
@@ -127,4 +127,10 @@ public void registerWorkerMemoryUsageGauge(Supplier<Number> supplier) {
.register(Metrics.globalRegistry);
}
+ public static void registerUncachedException(final Supplier<Number> supplier) {
+ Gauge.builder("ds.master.uncached.exception", supplier)
Review Comment:
we should change to ```ds.worker.uncached.exception ```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use DefaultUncaughtExceptionHandler to log the uncached exception [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15496:
URL: https://github.com/apache/dolphinscheduler/pull/15496#issuecomment-1897722303
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496) **Quality Gate failed**
Failed conditions
[40.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15496&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use DefaultUncaughtExceptionHandler to log the uncached exception [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15496:
URL: https://github.com/apache/dolphinscheduler/pull/15496#issuecomment-1895932961
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496) **Quality Gate failed**
Failed conditions
[40.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15496&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use DefaultUncaughtExceptionHandler to log the uncached exception [dolphinscheduler]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #15496:
URL: https://github.com/apache/dolphinscheduler/pull/15496#issuecomment-1893894874
## [Codecov](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `36 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`0b873e6`)](https://app.codecov.io/gh/apache/dolphinscheduler/commit/0b873e68705acab7cbd23b7c28c2844a2070c1a8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 38.04% compared to head [(`c25bae3`)](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 38.03%.
> :exclamation: Current head c25bae3 differs from pull request most recent head 0a90348. Consider uploading reports for the commit 0a90348 to get more accurate results
| [Files](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hinscheduler/alert/metrics/AlertServerMetrics.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9kb2xwaGluc2NoZWR1bGVyLWFsZXJ0LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9tZXRyaWNzL0FsZXJ0U2VydmVyTWV0cmljcy5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...dolphinscheduler/api/metrics/ApiServerMetrics.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL21ldHJpY3MvQXBpU2VydmVyTWV0cmljcy5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ler/server/master/metrics/MasterServerMetrics.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9tZXRyaWNzL01hc3RlclNlcnZlck1ldHJpY3MuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ler/server/worker/metrics/WorkerServerMetrics.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci13b3JrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9tZXRyaWNzL1dvcmtlclNlcnZlck1ldHJpY3MuamF2YQ==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/dolphinscheduler/alert/AlertServer.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9kb2xwaGluc2NoZWR1bGVyLWFsZXJ0LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9BbGVydFNlcnZlci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/dolphinscheduler/api/ApiApplicationServer.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL0FwaUFwcGxpY2F0aW9uU2VydmVyLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...lphinscheduler/common/thread/BaseDaemonThread.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9CYXNlRGFlbW9uVGhyZWFkLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/dolphinscheduler/server/master/MasterServer.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9NYXN0ZXJTZXJ2ZXIuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...uler/server/master/registry/ServerNodeManager.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9yZWdpc3RyeS9TZXJ2ZXJOb2RlTWFuYWdlci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/dolphinscheduler/server/worker/WorkerServer.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci13b3JrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9Xb3JrZXJTZXJ2ZXIuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [8 more](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## dev #15496 +/- ##
============================================
- Coverage 38.04% 38.03% -0.02%
- Complexity 4688 4692 +4
============================================
Files 1304 1304
Lines 44770 44754 -16
Branches 4799 4776 -23
============================================
- Hits 17031 17020 -11
+ Misses 25888 25885 -3
+ Partials 1851 1849 -2
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15496?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use DefaultUncaughtExceptionHandler to log the uncached exception [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15496:
URL: https://github.com/apache/dolphinscheduler/pull/15496#issuecomment-1894987167
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496) **Quality Gate failed**
Failed conditions
[40.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15496&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use DefaultUncaughtExceptionHandler to log the uncached exception [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on code in PR #15496:
URL: https://github.com/apache/dolphinscheduler/pull/15496#discussion_r1455555347
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/metrics/WorkerServerMetrics.java:
##########
@@ -127,4 +127,10 @@ public void registerWorkerMemoryUsageGauge(Supplier<Number> supplier) {
.register(Metrics.globalRegistry);
}
+ public static void registerUncachedException(final Supplier<Number> supplier) {
+ Gauge.builder("ds.master.uncached.exception", supplier)
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use DefaultUncaughtExceptionHandler to log the uncached exception [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15496:
URL: https://github.com/apache/dolphinscheduler/pull/15496#issuecomment-1895852203
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496) **Quality Gate failed**
Failed conditions
[40.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15496&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15496)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use DefaultUncaughtExceptionHandler to log the uncached exception [dolphinscheduler]
Posted by "fuchanghai (via GitHub)" <gi...@apache.org>.
fuchanghai merged PR #15496:
URL: https://github.com/apache/dolphinscheduler/pull/15496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org