You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "jdeppe-pivotal (GitHub)" <gi...@apache.org> on 2018/11/09 19:16:08 UTC

[GitHub] [geode] jdeppe-pivotal commented on issue #2825: GEODE-6027: refactor updateClusterConfig

@aditya87 @petahhh FYI on this PR
Although it might seem pointless to separate the `ResultModel` and `configObject` as params, my feeling is that these don't belong together and the only reason `RM` contains the `configObject` is because the commands return a `RM`. To that end, I'm also considering having commands return a `Pair<ResultModel, Object>` (http://commons.apache.org/proper/commons-lang/javadocs/api-3.8/index.html?org/apache/commons/lang3/tuple/Pair.html) allowing us to separate the two concerns.  Thoughts? 

[ Full content available at: https://github.com/apache/geode/pull/2825 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org