You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/26 21:54:14 UTC

[GitHub] [superset] jess-dillard commented on pull request #19855: feat(explore): Frontend implementation of dataset creation from infobox

jess-dillard commented on PR #19855:
URL: https://github.com/apache/superset/pull/19855#issuecomment-1110287562

   Thanks @lyndsiWilliams ! Two things: 
   
   1. The infobox shouldn't fill the full width of the sidebar (it should have the same gutter width on either side as the metrics/columns below it).
   2. I think we should remove the line of copy in the save dataset modal if it's opened from Explore – it doesn't make as much sense outside of SQL Lab.
   
   <img width="627" alt="Screen Shot 2022-04-26 at 2 50 44 PM" src="https://user-images.githubusercontent.com/90715511/165398757-46b87865-a690-436b-858d-120daba8f09b.png">


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org