You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datafu.apache.org by GitBox <gi...@apache.org> on 2022/10/08 09:19:37 UTC

[GitHub] [datafu] arpitbhardwaj opened a new pull request, #31: DATAFU-162: Upgraded to log4j2 in datafu-spark

arpitbhardwaj opened a new pull request, #31:
URL: https://github.com/apache/datafu/pull/31

   Upgraded Log4j version from Log4j1 (1.2.17) to Log4j2 (2.19.0) in datafu-spark.
   
   JIRA: [DATAFU-162](https://issues.apache.org/jira/browse/DATAFU-162)
   Refer: https://logging.apache.org/log4j/2.x/manual/migration.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datafu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [datafu] arpitbhardwaj commented on pull request #31: DATAFU-162: Upgraded to log4j2 in datafu-spark

Posted by GitBox <gi...@apache.org>.
arpitbhardwaj commented on PR #31:
URL: https://github.com/apache/datafu/pull/31#issuecomment-1275760780

   @eyala Yes i corrected the email in this PR commit. In last PR commit there was some other email got attached wrongly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datafu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [datafu] arpitbhardwaj commented on pull request #31: DATAFU-162: Upgraded to log4j2 in datafu-spark

Posted by GitBox <gi...@apache.org>.
arpitbhardwaj commented on PR #31:
URL: https://github.com/apache/datafu/pull/31#issuecomment-1275607047

   @eyala Thanks for pointing it out. 
   
   Found the cause it was happening due to missing log4j2 properties in test resources. 
   I have added it now and removed the older one. 
   
   Logger lines are now as it is master. Please verify and let me know.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datafu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [datafu] eyala commented on pull request #31: DATAFU-162: Upgraded to log4j2 in datafu-spark

Posted by GitBox <gi...@apache.org>.
eyala commented on PR #31:
URL: https://github.com/apache/datafu/pull/31#issuecomment-1274371690

   It seems to me like there are some changes in what is being logged. You can see this by comparing the gradle build results in _datafu-spark/build/test-results_ (between the master branch and yours).
   
   For example, this line is missing in DataframeOpsTests:
   
   `WARN apache.spark.SparkContext - Using an existing SparkContext; some configuration may not take effect.
   `
   
   And some messages with level _WARN hive.metastore.ObjectStore_ from TestScalaPythonBridge, and _WARN hive.metastore.ObjectStore_ from UdafTests.
   
   If it's just the default logging level in the tests, I think it's fine ... but if it will lead to a change in actual usage then less so.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datafu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [datafu] arpitbhardwaj commented on pull request #31: DATAFU-162: Upgraded to log4j2 in datafu-spark

Posted by GitBox <gi...@apache.org>.
arpitbhardwaj commented on PR #31:
URL: https://github.com/apache/datafu/pull/31#issuecomment-1274419563

   ok let me check the cause for missing lines


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datafu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [datafu] eyala commented on pull request #31: DATAFU-162: Upgraded to log4j2 in datafu-spark

Posted by GitBox <gi...@apache.org>.
eyala commented on PR #31:
URL: https://github.com/apache/datafu/pull/31#issuecomment-1275749710

   Hi @arpitbhardwaj , looks good.
   
   Did you see what I wrote about adding your email to your GitHub account? I do want your last commit to be included on your profile. At any rate, I will merge this one as it is, so the PR itself gets counted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datafu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [datafu] eyala merged pull request #31: DATAFU-162: Upgraded to log4j2 in datafu-spark

Posted by GitBox <gi...@apache.org>.
eyala merged PR #31:
URL: https://github.com/apache/datafu/pull/31


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datafu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org