You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "tanclary (via GitHub)" <gi...@apache.org> on 2023/06/07 17:22:17 UTC

[GitHub] [calcite] tanclary commented on a diff in pull request #3206: [CALCITE-5724] Generated SQL uses literal values in ORDER BY clauses

tanclary commented on code in PR #3206:
URL: https://github.com/apache/calcite/pull/3206#discussion_r1221942270


##########
core/src/main/java/org/apache/calcite/sql/validate/SqlConformanceEnum.java:
##########
@@ -397,6 +397,15 @@ public enum SqlConformanceEnum implements SqlConformance {
     }
   }
 
+  @Override public boolean isSortByLiteralAllowed() {
+    switch (this) {
+    case BIG_QUERY:
+      return false;

Review Comment:
   is it easy to check if other dialects allow this? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org