[jira] [Commented] (YUNIKORN-771) make license-check passes always on linux

["Wilfred Spiegelenburg (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391308#comment-17391308 ] 

Wilfred Spiegelenburg commented on YUNIKORN-771:
------------------------------------------------

This is a problem in all 3 repos that run a license check:
- core
- k8shim
- web

The scheduler interface adds the license to the generated files automatically and does not have a license check.
The release repository files are static and do not need a check.

> make license-check passes always on linux
> -----------------------------------------
>
>                 Key: YUNIKORN-771
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-771
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: build
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Wilfred Spiegelenburg
>            Priority: Major
>
> The {{make license-check}} always passes when run on linux.
> The recursive grep that is used never writes out any file information when redirected as part of the make. When run directly from the terminal the command works as expected.
> The command works without a problem when run as part of a make on MacOSX.
> The github action that is part of the PR workflow runs on linux. That means we never catch a missing license for a file during the PR review unless we see it by inspection.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org