You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Antoine Toulme (JIRA)" <ji...@apache.org> on 2010/07/17 09:27:49 UTC
[jira] Created: (BUILDR-481) Antwrap monkey-patching in core.rb
Antwrap monkey-patching in core.rb
----------------------------------
Key: BUILDR-481
URL: https://issues.apache.org/jira/browse/BUILDR-481
Project: Buildr
Issue Type: Task
Reporter: Antoine Toulme
Fix For: 1.4.2
In core.rb, there is a weird monkey-patching:
# TODO: Antwrap 0.7 requires this monkeypatch, have it fixed.
class Array #:nodoc:
alias :nitems :size
end
Changing ruby core classes is never a good idea, this should be removed and Antwrap should be fixed if needed to support this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (BUILDR-481) Antwrap monkey-patching in core.rb
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme reassigned BUILDR-481:
-------------------------------------
Assignee: Antoine Toulme
> Antwrap monkey-patching in core.rb
> ----------------------------------
>
> Key: BUILDR-481
> URL: https://issues.apache.org/jira/browse/BUILDR-481
> Project: Buildr
> Issue Type: Task
> Reporter: Antoine Toulme
> Assignee: Antoine Toulme
> Fix For: 1.4.2
>
>
> In core.rb, there is a weird monkey-patching:
> # TODO: Antwrap 0.7 requires this monkeypatch, have it fixed.
> class Array #:nodoc:
> alias :nitems :size
> end
> Changing ruby core classes is never a good idea, this should be removed and Antwrap should be fixed if needed to support this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-481) Antwrap monkey-patching in core.rb
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890559#action_12890559 ]
Hudson commented on BUILDR-481:
-------------------------------
Integrated in Buildr-ci-build #81 (See [http://hudson.zones.apache.org/hudson/job/Buildr-ci-build/81/])
> Antwrap monkey-patching in core.rb
> ----------------------------------
>
> Key: BUILDR-481
> URL: https://issues.apache.org/jira/browse/BUILDR-481
> Project: Buildr
> Issue Type: Task
> Reporter: Antoine Toulme
> Assignee: Antoine Toulme
> Fix For: 1.4.2
>
>
> In core.rb, there is a weird monkey-patching:
> # TODO: Antwrap 0.7 requires this monkeypatch, have it fixed.
> class Array #:nodoc:
> alias :nitems :size
> end
> Changing ruby core classes is never a good idea, this should be removed and Antwrap should be fixed if needed to support this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-481) Antwrap monkey-patching in core.rb
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme resolved BUILDR-481.
-----------------------------------
Resolution: Fixed
21:46:25~/w/buildr>svn ci CHANGELOG buildr.gemspec lib/buildr/core.rb -m "BUILDR-481 Antwrap monkey-patching in core.rb"
Sending CHANGELOG
Sending buildr.gemspec
Sending lib/buildr/core.rb
Transmitting file data ...
Committed revision 966084.
> Antwrap monkey-patching in core.rb
> ----------------------------------
>
> Key: BUILDR-481
> URL: https://issues.apache.org/jira/browse/BUILDR-481
> Project: Buildr
> Issue Type: Task
> Reporter: Antoine Toulme
> Assignee: Antoine Toulme
> Fix For: 1.4.2
>
>
> In core.rb, there is a weird monkey-patching:
> # TODO: Antwrap 0.7 requires this monkeypatch, have it fixed.
> class Array #:nodoc:
> alias :nitems :size
> end
> Changing ruby core classes is never a good idea, this should be removed and Antwrap should be fixed if needed to support this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-481) Antwrap monkey-patching in core.rb
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889932#action_12889932 ]
Antoine Toulme commented on BUILDR-481:
---------------------------------------
This is apparently a 1.9 compatibility issue, the log mentions it:
Array.nitems no longer exists, Antwrap requires this patch
I will contact the Antwrap maintainer.
> Antwrap monkey-patching in core.rb
> ----------------------------------
>
> Key: BUILDR-481
> URL: https://issues.apache.org/jira/browse/BUILDR-481
> Project: Buildr
> Issue Type: Task
> Reporter: Antoine Toulme
> Fix For: 1.4.2
>
>
> In core.rb, there is a weird monkey-patching:
> # TODO: Antwrap 0.7 requires this monkeypatch, have it fixed.
> class Array #:nodoc:
> alias :nitems :size
> end
> Changing ruby core classes is never a good idea, this should be removed and Antwrap should be fixed if needed to support this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-481) Antwrap monkey-patching in core.rb
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890303#action_12890303 ]
Antoine Toulme commented on BUILDR-481:
---------------------------------------
I forked the project and made the change. I will release the Antwrap fork under atoulme-Antwrap and we will use it as is for now.
> Antwrap monkey-patching in core.rb
> ----------------------------------
>
> Key: BUILDR-481
> URL: https://issues.apache.org/jira/browse/BUILDR-481
> Project: Buildr
> Issue Type: Task
> Reporter: Antoine Toulme
> Fix For: 1.4.2
>
>
> In core.rb, there is a weird monkey-patching:
> # TODO: Antwrap 0.7 requires this monkeypatch, have it fixed.
> class Array #:nodoc:
> alias :nitems :size
> end
> Changing ruby core classes is never a good idea, this should be removed and Antwrap should be fixed if needed to support this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.