[GitHub] [hadoop] adoroszlai opened a new pull request #1092: HDDS-1735. Result of author check is inverted

[GitBox <gi...@apache.org>]

adoroszlai opened a new pull request #1092: HDDS-1735. Result of author check is inverted
URL: https://github.com/apache/hadoop/pull/1092
 
 
   ## What changes were proposed in this pull request?
   
   Fix:
   
    1. author check fails when no violations are found
    2. author check violations are duplicated in the output
   
   Eg. https://ci.anzix.net/job/ozone-nightly/173/consoleText says that:
   
   ```
   The following tests are FAILED:
   
   [author]: author check is failed (https://ci.anzix.net/job/ozone-nightly/173//artifact/build/author.out/*view*/)
   ```
   
   but no actual `@author` tags were found:
   
   ```
   $ curl -s 'https://ci.anzix.net/job/ozone-nightly/173//artifact/build/author.out/*view*/' | wc
          0       0       0
   ```
   
   ## How was this patch tested?
   
   ```
   $ bash -o pipefail -c 'hadoop-ozone/dev-support/checks/author.sh | tee build/author.out'; echo $?
   0
   
   $ wc build/author.out
          0       0       0 build/author.out
   
   $ echo '// @author Tolkien' >> hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManager.java
   
   $ bash -o pipefail -c 'hadoop-ozone/dev-support/checks/author.sh | tee build/author.out'; echo $?
   ./hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManager.java:// @author Tolkien
   1
   
   $ wc build/author.out
          1       3     108 build/author.out
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org