[jira] [Commented] (GROOVY-8288) [Sql] withBatch fails when batchSize == number of addBatch call

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GROOVY-8288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126903#comment-16126903 ] 

ASF GitHub Bot commented on GROOVY-8288:
----------------------------------------

GitHub user akapps opened a pull request:

    https://github.com/apache/groovy/pull/586

    GROOVY-8288 executeBatch() should not be called with batchCount == 0

    This is a first proposition of resolution for [GROOVY-8288](https://issues.apache.org/jira/browse/GROOVY-8288).
    There still are open questions (see my comments on changes).
    
    Thank you for your feedback.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akapps/groovy GROOVY-8288-execute-batch

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/586.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #586
    
----
commit 7af055833f82606b12db5d66834ff1a4beaace2a
Author: Antoine Kapps <an...@orange.fr>
Date:   2017-08-15T07:42:26Z

    GROOVY-8288 executeBatch() should not be called with batchCount == 0

----


> [Sql] withBatch fails when batchSize == number of addBatch call
> ---------------------------------------------------------------
>
>                 Key: GROOVY-8288
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8288
>             Project: Groovy
>          Issue Type: Bug
>          Components: SQL processing
>    Affects Versions: 2.5.0-beta-1, 2.4.12
>            Reporter: Antoine Kapps
>
> {{Sql.withBatch(batchSize, ..)}} calls {{delegate.executeBatch()}} both when batchCount reaches batchSize, and at the end of the method (after the call to the "batch statement" closure).
> Thus, if the number of {{addBatch()}} calls in the closure is exactly the same as, or a multiple of {{batchSize}}, one too much call to {{executeBatch()}} is made : nothing has been added to the batch.
> Which, at least with HSQLDB 2.4.0, leads to a SQLException on that very last call.
> Test to reproduce (compliant with SqlBatchTest)
> {code:java}
> void testWithBatchSizeHavingSizeSameSizeAsStatements() {
>     def numRows = sql.rows("SELECT * FROM PERSON").size()
>     assert numRows == 3
>     def myOthers = ['f4':'l4','f5':'l5','f6':'l6','f7':'l7']
>     def result = sql.withBatch(myOthers.size(), "insert into PERSON (id, firstname, lastname) values (?, ?, ?)") { ps ->
>         myOthers.eachWithIndex { k, v, index ->
>             def id = index + numRows + 1
>             ps.addBatch(id, k, v)
>         }
>     }
>     assert result == [1] * myOthers.size()
>     assert sql.rows("SELECT * FROM PERSON").size() == numRows + myOthers.size()
>     // end result the same as if no batching was in place but logging should show:
>     // FINE: Successfully executed batch with 4 command(s)
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)