You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by we...@apache.org on 2017/04/21 21:44:39 UTC
arrow git commit: ARROW-616: [C++] Do not include debug symbols in
release builds by default
Repository: arrow
Updated Branches:
refs/heads/master 6867e93cc -> 16ea37030
ARROW-616: [C++] Do not include debug symbols in release builds by default
This reduces binary size on Linux by about 80-90%. If the user wants them, they can enable with `-DARROW_CXXFLAGS="-g"`.
Author: Wes McKinney <we...@twosigma.com>
Closes #574 from wesm/ARROW-616 and squashes the following commits:
71fc105 [Wes McKinney] Do not include debug symbols in release builds by default
Project: http://git-wip-us.apache.org/repos/asf/arrow/repo
Commit: http://git-wip-us.apache.org/repos/asf/arrow/commit/16ea3703
Tree: http://git-wip-us.apache.org/repos/asf/arrow/tree/16ea3703
Diff: http://git-wip-us.apache.org/repos/asf/arrow/diff/16ea3703
Branch: refs/heads/master
Commit: 16ea3703022304843c1eaef4a75636dbdc49e8e5
Parents: 6867e93
Author: Wes McKinney <we...@twosigma.com>
Authored: Fri Apr 21 17:44:26 2017 -0400
Committer: Wes McKinney <we...@twosigma.com>
Committed: Fri Apr 21 17:44:26 2017 -0400
----------------------------------------------------------------------
cpp/cmake_modules/SetupCxxFlags.cmake | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/arrow/blob/16ea3703/cpp/cmake_modules/SetupCxxFlags.cmake
----------------------------------------------------------------------
diff --git a/cpp/cmake_modules/SetupCxxFlags.cmake b/cpp/cmake_modules/SetupCxxFlags.cmake
index 7e229ff..e210655 100644
--- a/cpp/cmake_modules/SetupCxxFlags.cmake
+++ b/cpp/cmake_modules/SetupCxxFlags.cmake
@@ -71,11 +71,12 @@ endif()
# Same as DEBUG, except with some optimizations on.
# For CMAKE_BUILD_TYPE=Release
# -O3: Enable all compiler optimizations
-# -g: Enable symbols for profiler tools (TODO: remove for shipping)
+# Debug symbols are stripped for reduced binary size. Add
+# -DARROW_CXXFLAGS="-g" to add them
if (NOT MSVC)
set(CXX_FLAGS_DEBUG "-ggdb -O0")
set(CXX_FLAGS_FASTDEBUG "-ggdb -O1")
- set(CXX_FLAGS_RELEASE "-O3 -g -DNDEBUG")
+ set(CXX_FLAGS_RELEASE "-O3 -DNDEBUG")
endif()
set(CXX_FLAGS_PROFILE_GEN "${CXX_FLAGS_RELEASE} -fprofile-generate")