You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2022/05/20 07:48:51 UTC
[GitHub] [jena] SimonBin opened a new pull request, #1330: add geof:asGeoJSON function
SimonBin opened a new pull request, #1330:
URL: https://github.com/apache/jena/pull/1330
suggestion to add a GeoJSON conversion function
this will add a dependency on jts-io-common
it is not support for reading GeoJSON nor full implementation of GeoJSON data type, but it can be useful in SPARQL for web applications that wish to consume GeoJSON
co-authored with @LorenzBuehmann
https://opengeospatial.github.io/ogc-geosparql/geosparql11/spec.html#_function_geofasgeojson
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #1330: add geof:asGeoJSON function
Posted by GitBox <gi...@apache.org>.
afs merged PR #1330:
URL: https://github.com/apache/jena/pull/1330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a diff in pull request #1330: add geof:asGeoJSON function
Posted by GitBox <gi...@apache.org>.
afs commented on code in PR #1330:
URL: https://github.com/apache/jena/pull/1330#discussion_r894849052
##########
jena-geosparql/src/test/java/org/apache/jena/geosparql/geof/nontopological/filter_functions/AsGeoJSONFFTest.java:
##########
@@ -0,0 +1,61 @@
+package org.apache.jena.geosparql.geof.nontopological.filter_functions;
+
+import org.apache.jena.geosparql.implementation.datatype.GMLDatatype;
+import org.apache.jena.geosparql.implementation.datatype.GeoJSONDatatype;
+import org.apache.jena.sparql.expr.NodeValue;
+import org.junit.*;
+import org.locationtech.jts.geom.GeometryFactory;
+import org.locationtech.jts.geom.LineString;
+import org.locationtech.jts.io.ParseException;
+import org.locationtech.jts.io.geojson.GeoJsonReader;
+
+import static org.junit.Assert.assertTrue;
+
+public class AsGeoJSONFFTest {
+ private static final double TOLERANCE = 0.0001;
+
+ public AsGeoJSONFFTest() {
+ }
+
+ @BeforeClass
Review Comment:
These don't need to be here if they are empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a diff in pull request #1330: add geof:asGeoJSON function
Posted by GitBox <gi...@apache.org>.
afs commented on code in PR #1330:
URL: https://github.com/apache/jena/pull/1330#discussion_r894791871
##########
jena-geosparql/pom.xml:
##########
@@ -67,6 +67,11 @@
<artifactId>jts-core</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.locationtech.jts.io</groupId>
+ <artifactId>jts-io-common</artifactId>
Review Comment:
There are licensing considerations for this artifact.
It is available under EDL 1.0 (Eclipse Distribution License) which is acceptable - it requires an acknowledgement in any binaries Apache Jena ships (jena-geosparql, jena-fuseki-geosparql).
That should already be covered by jts-core
There do not seem to be any recursive dependencies.
##########
jena-geosparql/src/test/java/org/apache/jena/geosparql/geof/nontopological/filter_functions/AsGeoJSONFFTest.java:
##########
@@ -0,0 +1,61 @@
+package org.apache.jena.geosparql.geof.nontopological.filter_functions;
+
+import org.apache.jena.geosparql.implementation.datatype.GMLDatatype;
+import org.apache.jena.geosparql.implementation.datatype.GeoJSONDatatype;
+import org.apache.jena.sparql.expr.NodeValue;
+import org.junit.*;
+import org.locationtech.jts.geom.GeometryFactory;
+import org.locationtech.jts.geom.LineString;
+import org.locationtech.jts.io.ParseException;
+import org.locationtech.jts.io.geojson.GeoJsonReader;
+
+import static org.junit.Assert.assertTrue;
+
+public class AsGeoJSONFFTest {
+ private static final double TOLERANCE = 0.0001;
+
+ public AsGeoJSONFFTest() {
+ }
+
+ @BeforeClass
Review Comment:
These don't need to be heer if they are empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1330: add geof:asGeoJSON function
Posted by GitBox <gi...@apache.org>.
afs commented on PR #1330:
URL: https://github.com/apache/jena/pull/1330#issuecomment-1152690045
Looks OK except for some details.
The build does not run.
Please add the Apache header (the same as in other java files in Apache Jena) to:
`AsGeoJSONFFTest.java`
`AsGeoJSONFF.java`
`GeoJSONDatatype.java`
You can run the build with `mvn clean install` or `mvn clean install -Pdev` (although that does not include jena-fuseki-geosparql).
GeoJSON is mentioned at https://jena.apache.org/documentation/geosparql/, (source: https://github.com/apache/jena-site/blob/main/source/documentation/geosparql/__index.md) which needs updating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1330: add geof:asGeoJSON function
Posted by GitBox <gi...@apache.org>.
afs commented on PR #1330:
URL: https://github.com/apache/jena/pull/1330#issuecomment-1154151765
Tracking issue: https://github.com/apache/jena/issues/1383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org