[jira] [Commented] (STORM-1213) Remove sigar binaries from source tree

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008771#comment-15008771 ] 

ASF GitHub Bot commented on STORM-1213:
---------------------------------------

GitHub user ptgoetz opened a pull request:

    https://github.com/apache/storm/pull/887

    STORM-1213: Remove sigar binaries from source tree

    See https://issues.apache.org/jira/browse/STORM-1213 for description.
    
    Also removes the LICENSE entry for sigar, since I believe that is unnecessary since it is Apache licensed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ptgoetz/storm storm-metrics-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/887.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #887
    
----
commit 83eced3329dc62c685aa6784792506766343fd52
Author: P. Taylor Goetz <pt...@gmail.com>
Date:   2015-11-16T22:17:19Z

    remove sigar binaries from source tree and delete unnecessary LICENSE entry

----


> Remove sigar binaries from source tree
> --------------------------------------
>
>                 Key: STORM-1213
>                 URL: https://issues.apache.org/jira/browse/STORM-1213
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.11.0
>            Reporter: P. Taylor Goetz
>            Assignee: P. Taylor Goetz
>
> In {{external/storm-metrics}} sigar native binaries were added to the source tree. Since Apache releases are source-only, these binaries can't be included in a release.
> My initial thought was just to exclude the binaries from the source distribution, but that would mean that distributions built from a source tarball would not match the convenience binaries from a release (the sigar native binaries would not be included.
> The solution I came up with was to leverage the fact that pre-built native binaries are included in the sigar maven distribution ({{sigar-x.x.x-native.jar}}) and use the maven dependency plugin to unpack them into place during the build, rather than check them into git. One benefit is that it will ensure the versions of the sigar jar and the native binaries match. Another is that mavens checksum/signature checking mechanism will also be applied.
> This isn't an ideal solution since the {{sigar-x.x.x-native.jar}} only includes binaries for linux, OSX, and solaris (notably missing windows DLLs), whereas the non-maven sigar download includes support for a wider range of OSes and architectures.
> I view this as an interim measure until we can find a better way to include the native binaries in the build process, rather than checking them into the source tree -- which would be a blocker for releasing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)