[PR] fix(header): render toggle icons on first load [fineract-backoffice-ui]

["alloutflo (via GitHub)" <gi...@apache.org>]

alloutflo opened a new pull request, #304:
URL: https://github.com/apache/fineract-backoffice-ui/pull/304

   ## What and why
   
   Render the sidebar and theme toggle icons from separate, statically named
   `ion-icon` elements. This gives Ionic the icon name before each element is
   connected, so both controls are visible on the initial page load while still
   switching icons when their state changes.
   
   Closes #263
   
   ## Verification
   
   - `npm test -- --watch=false --include='src/app/layout/header.component.spec.ts'` (4 passed)
   - `npm test -- --watch=false` (843 passed)
   - `npm run check:icons` (114 registered icons)
   - `npx eslint src/app/layout/header.component.ts --suppressions-location eslint-suppressions.json`
   - `npx prettier --check src/app/layout/header.component.ts`
   - `npm run build`
   
   The local HTTPS development server built successfully. A screenshot is not
   included because the Codex in-app browser does not trust the repository's
   local self-signed certificate; no real Fineract backend was exercised.
   
   ## Screenshots
   
   Not available for the local self-signed HTTPS environment. The change is
   limited to how the two existing icons are instantiated; it does not alter
   layout, styling, labels, or behavior.
   
   ## Checklist
   
   - [x] I did not hand-edit generated files under `src/app/api/`.
   - [x] No new component or service code was added, so the adapter boundary is not applicable.
   - [x] No user-facing strings were added or changed.
   - [x] Existing header coverage and the complete 843-test suite pass. A new unit test would not reproduce Ionic's custom-element connection timing, because Angular DOM assertions run after bindings settle.
   - [x] This is not a workflow change, so additional e2e coverage is not applicable.
   - [x] The commit is signed and GitHub reports the signature as verified.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(header): render toggle icons on first load [fineract-backoffice-ui]

["Aman-Mittal (via GitHub)" <gi...@apache.org>]

Aman-Mittal merged PR #304:
URL: https://github.com/apache/fineract-backoffice-ui/pull/304


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org