You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/02/27 17:10:03 UTC

[GitHub] tysonnorris commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110

tysonnorris commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110
URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r170996623
 
 

 ##########
 File path: core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainerFactory.scala
 ##########
 @@ -67,13 +70,13 @@ class DockerContainerFactory(config: WhiskConfig,
       image = image,
       userProvidedImage = userProvidedImage,
       memory = memory,
-      cpuShares = config.invokerCoreShare.toInt,
+      cpuShares = poolConfig.cpuShare,
 
 Review comment:
   Philosophically I'm ok with this, but I'm not sure about how to update KubernetesContainerFactory to respect this change; @dgrove-oss WDYT?
   
   For the time being, it may be better to leave this to a separate PR, since it is changing the ContainerFactory SPI interface.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services