You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/07 00:51:36 UTC
[GitHub] [skywalking] wu-sheng opened a new pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
wu-sheng opened a new pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
### <Feature description>
- [x] If this is non-trivial feature, paste the links/URLs to the design doc.
Support better adoption for native BanyanDB #6315
- [x] Update the documentation to include this new feature.
Due to core level code change only, no feature related to end users. Nothing to update
- [x] Tests(including UT, IT, E2E) are added to verify the new feature.
Still covered by existing e2e
- [x] If it's UI related, attach the screenshots below.
Not related
I add a new service in the Storage Module. Override this service could provide new OAL builder generator template, and existing manual/auto-generated Builders.
```java
/**
* StorageBuilderFactory provides the capabilities to override the default storage builders, which are implementations
* of {@link StorageHashMapBuilder}.
*
* Typically, the storage needs to provide a more native format rather than {@link java.util.HashMap}.
*/
public interface StorageBuilderFactory extends Service {
/**
* @return the builder definition for OAL Engine.
*/
BuilderTemplateDefinition builderTemplate();
/**
* Fetch the real builder by the given type of stream data and the static declared by the {@link Stream#builder()}.
*
* @param dataType of the stream data.
* @param defaultBuilder static builder.
* @return the builder used in the runtime.
*/
Class<? extends StorageBuilder> builderOf(Class<? extends StorageData> dataType,
Class<? extends StorageBuilder> defaultBuilder);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (26fdeaf) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `16.46%`.
> The diff coverage is `82.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 39.51% -16.47%
+ Complexity 3901 2326 -1575
=============================================
Files 973 793 -180
Lines 24216 19591 -4625
Branches 2394 1849 -545
=============================================
- Hits 13556 7742 -5814
- Misses 9464 11264 +1800
+ Partials 1196 585 -611
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [402 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...f4888af](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (1a836ca) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `11.15%`.
> The diff coverage is `82.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 44.82% -11.16%
+ Complexity 3901 2627 -1274
=============================================
Files 973 793 -180
Lines 24216 19725 -4491
Branches 2394 1879 -515
=============================================
- Hits 13556 8842 -4714
- Misses 9464 10194 +730
+ Partials 1196 689 -507
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [338 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...1a836ca](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (850a065) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `6.93%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
- Coverage 55.97% 49.04% -6.94%
+ Complexity 3901 3505 -396
============================================
Files 973 962 -11
Lines 24216 23880 -336
Branches 2394 2356 -38
============================================
- Hits 13556 11711 -1845
- Misses 9464 11140 +1676
+ Partials 1196 1029 -167
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [155 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (26fdeaf) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `1.84%`.
> The diff coverage is `83.01%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
- Coverage 55.97% 54.13% -1.85%
+ Complexity 3901 3796 -105
============================================
Files 973 962 -11
Lines 24216 23946 -270
Branches 2394 2361 -33
============================================
- Hits 13556 12962 -594
- Misses 9464 9850 +386
+ Partials 1196 1134 -62
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [56 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...f4888af](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (26fdeaf) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `28.53%`.
> The diff coverage is `78.84%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 27.44% -28.54%
+ Complexity 3901 1695 -2206
=============================================
Files 973 792 -181
Lines 24216 19398 -4818
Branches 2394 1809 -585
=============================================
- Hits 13556 5324 -8232
- Misses 9464 13705 +4241
+ Partials 1196 369 -827
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.06% <0.00%> (-61.61%)` | `2.00 <0.00> (-7.00)` | |
| [...storage/plugin/influxdb/InfluxStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9JbmZsdXhTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `11.62% <0.00%> (-83.62%)` | `3.00 <0.00> (-6.00)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| ... and [515 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...f4888af](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (850a065) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `0.17%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
- Coverage 55.97% 55.80% -0.18%
+ Complexity 3901 3854 -47
============================================
Files 973 962 -11
Lines 24216 23929 -287
Branches 2394 2357 -37
============================================
- Hits 13556 13353 -203
+ Misses 9464 9416 -48
+ Partials 1196 1160 -36
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [49 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (26fdeaf) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `10.45%`.
> The diff coverage is `83.01%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 45.52% -10.46%
+ Complexity 3901 2710 -1191
=============================================
Files 973 811 -162
Lines 24216 20280 -3936
Branches 2394 1954 -440
=============================================
- Hits 13556 9233 -4323
- Misses 9464 10310 +846
+ Partials 1196 737 -459
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [306 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...f4888af](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (1a836ca) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `29.25%`.
> The diff coverage is `76.92%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 26.72% -29.26%
+ Complexity 3901 1664 -2237
=============================================
Files 973 792 -181
Lines 24216 19527 -4689
Branches 2394 1844 -550
=============================================
- Hits 13556 5219 -8337
- Misses 9464 13933 +4469
+ Partials 1196 375 -821
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...storage/plugin/influxdb/InfluxStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9JbmZsdXhTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `11.62% <0.00%> (-83.62%)` | `3.00 <0.00> (-6.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `7.24% <0.00%> (-78.05%)` | `3.00 <0.00> (-6.00)` | |
| [...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `8.47% <0.00%> (-74.29%)` | `3.00 <0.00> (-6.00)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| ... and [516 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...1a836ca](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (850a065) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **increase** coverage by `0.15%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
+ Coverage 55.97% 56.13% +0.15%
+ Complexity 3901 3862 -39
============================================
Files 973 962 -11
Lines 24216 23929 -287
Branches 2394 2357 -37
============================================
- Hits 13556 13432 -124
+ Misses 9464 9319 -145
+ Partials 1196 1178 -18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [45 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (1a836ca) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `12.61%`.
> The diff coverage is `80.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 43.36% -12.62%
+ Complexity 3901 2558 -1343
=============================================
Files 973 793 -180
Lines 24216 19707 -4509
Branches 2394 1878 -516
=============================================
- Hits 13556 8545 -5011
- Misses 9464 10477 +1013
+ Partials 1196 685 -511
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `8.47% <0.00%> (-74.29%)` | `3.00 <0.00> (-6.00)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [362 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...1a836ca](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (26fdeaf) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `1.97%`.
> The diff coverage is `83.01%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
- Coverage 55.97% 54.00% -1.98%
+ Complexity 3901 3793 -108
============================================
Files 973 962 -11
Lines 24216 23946 -270
Branches 2394 2361 -33
============================================
- Hits 13556 12931 -625
- Misses 9464 9889 +425
+ Partials 1196 1126 -70
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [57 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...f4888af](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (850a065) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `13.94%`.
> The diff coverage is `79.24%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 42.03% -13.95%
+ Complexity 3901 2470 -1431
=============================================
Files 973 793 -180
Lines 24216 19713 -4503
Branches 2394 1892 -502
=============================================
- Hits 13556 8286 -5270
- Misses 9464 10771 +1307
+ Partials 1196 656 -540
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.06% <0.00%> (-61.61%)` | `2.00 <0.00> (-7.00)` | |
| [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `8.33% <0.00%> (-74.72%)` | `3.00 <0.00> (-6.00)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| ... and [347 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (850a065) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `28.53%`.
> The diff coverage is `77.35%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 27.44% -28.54%
+ Complexity 3901 1695 -2206
=============================================
Files 973 792 -181
Lines 24216 19399 -4817
Branches 2394 1809 -585
=============================================
- Hits 13556 5324 -8232
- Misses 9464 13706 +4242
+ Partials 1196 369 -827
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.06% <0.00%> (-61.61%)` | `2.00 <0.00> (-7.00)` | |
| [...storage/plugin/influxdb/InfluxStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9JbmZsdXhTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `11.62% <0.00%> (-83.62%)` | `3.00 <0.00> (-6.00)` | |
| [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `8.33% <0.00%> (-74.72%)` | `3.00 <0.00> (-6.00)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| ... and [516 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (26fdeaf) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `2.02%`.
> The diff coverage is `83.01%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
- Coverage 55.97% 53.95% -2.03%
+ Complexity 3901 3789 -112
============================================
Files 973 962 -11
Lines 24216 23946 -270
Branches 2394 2361 -33
============================================
- Hits 13556 12920 -636
- Misses 9464 9901 +437
+ Partials 1196 1125 -71
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [62 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...f4888af](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (850a065) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `0.56%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
- Coverage 55.97% 55.41% -0.57%
+ Complexity 3901 3832 -69
============================================
Files 973 962 -11
Lines 24216 23916 -300
Branches 2394 2357 -37
============================================
- Hits 13556 13253 -303
- Misses 9464 9515 +51
+ Partials 1196 1148 -48
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [56 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (850a065) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **increase** coverage by `0.79%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
+ Coverage 55.97% 56.77% +0.79%
- Complexity 3901 3909 +8
============================================
Files 973 962 -11
Lines 24216 23957 -259
Branches 2394 2362 -32
============================================
+ Hits 13556 13602 +46
+ Misses 9464 9159 -305
Partials 1196 1196
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [36 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (1a836ca) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `10.75%`.
> The diff coverage is `82.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 45.22% -10.76%
+ Complexity 3901 2659 -1242
=============================================
Files 973 793 -180
Lines 24216 19746 -4470
Branches 2394 1896 -498
=============================================
- Hits 13556 8931 -4625
- Misses 9464 10123 +659
+ Partials 1196 692 -504
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [320 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...1a836ca](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (1a836ca) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `10.87%`.
> The diff coverage is `82.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 45.10% -10.88%
+ Complexity 3901 2650 -1251
=============================================
Files 973 793 -180
Lines 24216 19746 -4470
Branches 2394 1896 -498
=============================================
- Hits 13556 8906 -4650
- Misses 9464 10147 +683
+ Partials 1196 693 -503
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [324 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...1a836ca](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (1a836ca) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `3.74%`.
> The diff coverage is `82.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
- Coverage 55.97% 52.23% -3.75%
+ Complexity 3901 3659 -242
============================================
Files 973 944 -29
Lines 24216 23423 -793
Branches 2394 2307 -87
============================================
- Hits 13556 12235 -1321
- Misses 9464 10129 +665
+ Partials 1196 1059 -137
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [92 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (58105b6) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `23.65%`.
> The diff coverage is `76.92%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 32.32% -23.66%
+ Complexity 3901 1930 -1971
=============================================
Files 973 792 -181
Lines 24216 19475 -4741
Branches 2394 1837 -557
=============================================
- Hits 13556 6295 -7261
- Misses 9464 12732 +3268
+ Partials 1196 448 -748
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.06% <0.00%> (-61.61%)` | `2.00 <0.00> (-7.00)` | |
| [...storage/plugin/influxdb/InfluxStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9JbmZsdXhTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `11.62% <0.00%> (-83.62%)` | `3.00 <0.00> (-6.00)` | |
| [...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `8.47% <0.00%> (-74.29%)` | `3.00 <0.00> (-6.00)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| ... and [467 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...1a836ca](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (26fdeaf) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `28.94%`.
> The diff coverage is `76.92%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 27.03% -28.95%
+ Complexity 3901 1677 -2224
=============================================
Files 973 792 -181
Lines 24216 19398 -4818
Branches 2394 1809 -585
=============================================
- Hits 13556 5245 -8311
- Misses 9464 13786 +4322
+ Partials 1196 367 -829
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.06% <0.00%> (-61.61%)` | `2.00 <0.00> (-7.00)` | |
| [...storage/plugin/influxdb/InfluxStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9JbmZsdXhTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `11.62% <0.00%> (-83.62%)` | `3.00 <0.00> (-6.00)` | |
| [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `7.24% <0.00%> (-78.05%)` | `3.00 <0.00> (-6.00)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| ... and [521 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...f4888af](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (1a836ca) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `10.67%`.
> The diff coverage is `82.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 45.30% -10.68%
+ Complexity 3901 2665 -1236
=============================================
Files 973 793 -180
Lines 24216 19746 -4470
Branches 2394 1896 -498
=============================================
- Hits 13556 8945 -4611
- Misses 9464 10109 +645
+ Partials 1196 692 -504
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [321 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...1a836ca](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (bf34aa8) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `26.84%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 29.13% -26.85%
=============================================
Files 973 1655 +682
Lines 24216 34756 +10540
Branches 2394 4598 +2204
=============================================
- Hits 13556 10125 -3431
- Misses 9464 23689 +14225
+ Partials 1196 942 -254
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `0.00% <0.00%> (-63.18%)` | `0.00 <0.00> (-29.00)` | |
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `0.00% <0.00%> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00 <0.00> (-5.00)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (-88.71%)` | `0.00 <0.00> (-10.00)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00 <0.00> (-5.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-76.20%)` | `0.00 <0.00> (-5.00)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (-65.39%)` | `0.00 <0.00> (-4.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00 <0.00> (-4.00)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
| ... and [1681 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (850a065) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **increase** coverage by `0.28%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
+ Coverage 55.97% 56.26% +0.28%
+ Complexity 3901 3866 -35
============================================
Files 973 962 -11
Lines 24216 23929 -287
Branches 2394 2357 -37
============================================
- Hits 13556 13463 -93
+ Misses 9464 9277 -187
+ Partials 1196 1189 -7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [44 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (850a065) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **increase** coverage by `0.11%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
+ Coverage 55.97% 56.09% +0.11%
+ Complexity 3901 3861 -40
============================================
Files 973 962 -11
Lines 24216 23929 -287
Branches 2394 2357 -37
============================================
- Hits 13556 13424 -132
+ Misses 9464 9327 -137
+ Partials 1196 1178 -18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [46 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (26fdeaf) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `11.27%`.
> The diff coverage is `82.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 44.70% -11.28%
+ Complexity 3901 2608 -1293
=============================================
Files 973 793 -180
Lines 24216 19746 -4470
Branches 2394 1896 -498
=============================================
- Hits 13556 8827 -4729
- Misses 9464 10220 +756
+ Partials 1196 699 -497
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [329 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...f4888af](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (26fdeaf) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `10.83%`.
> The diff coverage is `82.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 45.14% -10.84%
+ Complexity 3901 2638 -1263
=============================================
Files 973 793 -180
Lines 24216 19774 -4442
Branches 2394 1901 -493
=============================================
- Hits 13556 8927 -4629
- Misses 9464 10142 +678
+ Partials 1196 705 -491
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [323 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...f4888af](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (26fdeaf) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `26.16%`.
> The diff coverage is `80.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 29.81% -26.17%
+ Complexity 3901 1822 -2079
=============================================
Files 973 792 -181
Lines 24216 19398 -4818
Branches 2394 1809 -585
=============================================
- Hits 13556 5784 -7772
- Misses 9464 13194 +3730
+ Partials 1196 420 -776
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.06% <0.00%> (-61.61%)` | `2.00 <0.00> (-7.00)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [499 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...f4888af](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (1a836ca) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `3.74%`.
> The diff coverage is `82.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
- Coverage 55.97% 52.23% -3.75%
+ Complexity 3901 3659 -242
============================================
Files 973 944 -29
Lines 24216 23423 -793
Branches 2394 2307 -87
============================================
- Hits 13556 12235 -1321
- Misses 9464 10129 +665
+ Partials 1196 1059 -137
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [92 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...1a836ca](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (26fdeaf) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `5.66%`.
> The diff coverage is `83.01%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
- Coverage 55.97% 50.31% -5.67%
+ Complexity 3901 2950 -951
============================================
Files 973 811 -162
Lines 24216 20329 -3887
Branches 2394 1955 -439
============================================
- Hits 13556 10228 -3328
+ Misses 9464 9295 -169
+ Partials 1196 806 -390
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [233 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...f4888af](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (850a065) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `2.13%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
- Coverage 55.97% 53.84% -2.14%
+ Complexity 3901 3760 -141
============================================
Files 973 962 -11
Lines 24216 23916 -300
Branches 2394 2357 -37
============================================
- Hits 13556 12878 -678
- Misses 9464 9910 +446
+ Partials 1196 1128 -68
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [88 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (850a065) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **increase** coverage by `0.40%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
+ Coverage 55.97% 56.38% +0.40%
+ Complexity 3901 3878 -23
============================================
Files 973 962 -11
Lines 24216 23929 -287
Branches 2394 2357 -37
============================================
- Hits 13556 13492 -64
+ Misses 9464 9248 -216
+ Partials 1196 1189 -7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [44 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (850a065) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **increase** coverage by `0.37%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
+ Coverage 55.97% 56.35% +0.37%
+ Complexity 3901 3872 -29
============================================
Files 973 962 -11
Lines 24216 23929 -287
Branches 2394 2357 -37
============================================
- Hits 13556 13485 -71
+ Misses 9464 9255 -209
+ Partials 1196 1189 -7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [42 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (850a065) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `11.37%`.
> The diff coverage is `79.62%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 44.60% -11.38%
+ Complexity 3901 2675 -1226
=============================================
Files 973 811 -162
Lines 24216 20253 -3963
Branches 2394 1949 -445
=============================================
- Hits 13556 9034 -4522
- Misses 9464 10513 +1049
+ Partials 1196 706 -490
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `12.94% <0.00%> (-53.73%)` | `3.00 <0.00> (-6.00)` | |
| [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `8.33% <0.00%> (-74.72%)` | `3.00 <0.00> (-6.00)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| ... and [314 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (850a065) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **increase** coverage by `0.75%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
+ Coverage 55.97% 56.73% +0.75%
- Complexity 3901 3908 +7
============================================
Files 973 962 -11
Lines 24216 23957 -259
Branches 2394 2362 -32
============================================
+ Hits 13556 13592 +36
+ Misses 9464 9170 -294
+ Partials 1196 1195 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [37 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (850a065) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `1.27%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
- Coverage 55.97% 54.70% -1.28%
+ Complexity 3901 3806 -95
============================================
Files 973 962 -11
Lines 24216 23916 -300
Branches 2394 2357 -37
============================================
- Hits 13556 13084 -472
- Misses 9464 9693 +229
+ Partials 1196 1139 -57
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [63 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (850a065) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `0.05%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
- Coverage 55.97% 55.92% -0.06%
+ Complexity 3901 3857 -44
============================================
Files 973 962 -11
Lines 24216 23929 -287
Branches 2394 2357 -37
============================================
- Hits 13556 13382 -174
+ Misses 9464 9378 -86
+ Partials 1196 1169 -27
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [48 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (26fdeaf) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `11.83%`.
> The diff coverage is `82.69%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 44.14% -11.84%
+ Complexity 3901 2584 -1317
=============================================
Files 973 793 -180
Lines 24216 19735 -4481
Branches 2394 1881 -513
=============================================
- Hits 13556 8712 -4844
- Misses 9464 10323 +859
+ Partials 1196 700 -496
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [345 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...f4888af](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (850a065) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `5.90%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
- Coverage 55.97% 50.07% -5.91%
+ Complexity 3901 3557 -344
============================================
Files 973 962 -11
Lines 24216 23880 -336
Branches 2394 2356 -38
============================================
- Hits 13556 11958 -1598
- Misses 9464 10866 +1402
+ Partials 1196 1056 -140
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [148 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (850a065) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **increase** coverage by `0.79%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
+ Coverage 55.97% 56.77% +0.79%
- Complexity 3901 3909 +8
============================================
Files 973 962 -11
Lines 24216 23957 -259
Branches 2394 2362 -32
============================================
+ Hits 13556 13602 +46
+ Misses 9464 9159 -305
Partials 1196 1196
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [36 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (850a065) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `10.69%`.
> The diff coverage is `79.62%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 45.27% -10.70%
+ Complexity 3901 2697 -1204
=============================================
Files 973 811 -162
Lines 24216 20263 -3953
Branches 2394 1950 -444
=============================================
- Hits 13556 9175 -4381
- Misses 9464 10366 +902
+ Partials 1196 722 -474
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `12.94% <0.00%> (-53.73%)` | `3.00 <0.00> (-6.00)` | |
| [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `8.33% <0.00%> (-74.72%)` | `3.00 <0.00> (-6.00)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| ... and [307 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (26fdeaf) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `8.18%`.
> The diff coverage is `83.01%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
============================================
- Coverage 55.97% 47.79% -8.19%
+ Complexity 3901 2812 -1089
============================================
Files 973 811 -162
Lines 24216 20316 -3900
Branches 2394 1955 -439
============================================
- Hits 13556 9710 -3846
- Misses 9464 9836 +372
+ Partials 1196 770 -426
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | `100.00% <100.00%> (ø)` | `2.00 <1.00> (ø)` | |
| ... and [281 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...f4888af](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (1a836ca) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `12.63%`.
> The diff coverage is `80.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 43.34% -12.64%
+ Complexity 3901 2555 -1346
=============================================
Files 973 793 -180
Lines 24216 19707 -4509
Branches 2394 1878 -516
=============================================
- Hits 13556 8542 -5014
- Misses 9464 10477 +1013
+ Partials 1196 688 -508
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `8.47% <0.00%> (-74.29%)` | `3.00 <0.00> (-6.00)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <100.00%> (+0.60%)` | `30.00 <1.00> (+1.00)` | |
| [...oap/server/core/oal/rt/OALEngineLoaderService.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvb2FsL3J0L09BTEVuZ2luZUxvYWRlclNlcnZpY2UuamF2YQ==) | `91.30% <100.00%> (+1.30%)` | `4.00 <0.00> (ø)` | |
| [...oap/server/core/storage/StorageBuilderFactory.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlQnVpbGRlckZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [361 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...1a836ca](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6336: Support multiple implementations of StorageBuilder in different storage implementations - stage 2
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6336:
URL: https://github.com/apache/skywalking/pull/6336#issuecomment-774570173
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=h1) Report
> Merging [#6336](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=desc) (850a065) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `29.30%`.
> The diff coverage is `75.47%`.
[](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6336 +/- ##
=============================================
- Coverage 55.97% 26.67% -29.31%
+ Complexity 3901 1652 -2249
=============================================
Files 973 792 -181
Lines 24216 19399 -4817
Branches 2394 1809 -585
=============================================
- Hits 13556 5174 -8382
- Misses 9464 13857 +4393
+ Partials 1196 368 -828
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
| [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.06% <0.00%> (-61.61%)` | `2.00 <0.00> (-7.00)` | |
| [...storage/plugin/influxdb/InfluxStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9JbmZsdXhTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `11.62% <0.00%> (-83.62%)` | `3.00 <0.00> (-6.00)` | |
| [...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `8.47% <0.00%> (-74.29%)` | `3.00 <0.00> (-6.00)` | |
| [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `8.33% <0.00%> (-74.72%)` | `3.00 <0.00> (-6.00)` | |
| [...rver/core/analysis/worker/TopNStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5TdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `75.00% <62.50%> (+9.61%)` | `4.00 <1.00> (ø)` | |
| [...ore/analysis/worker/ManagementStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01hbmFnZW1lbnRTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `82.60% <83.33%> (+11.18%)` | `5.00 <1.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `92.18% <83.33%> (+3.47%)` | `10.00 <3.00> (ø)` | |
| [...rver/core/analysis/worker/NoneStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `69.56% <83.33%> (-1.87%)` | `4.00 <1.00> (-1.00)` | |
| [...er/core/analysis/worker/RecordStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1JlY29yZFN0cmVhbVByb2Nlc3Nvci5qYXZh) | `86.95% <83.33%> (+10.76%)` | `5.00 <1.00> (ø)` | |
| ... and [524 more](https://codecov.io/gh/apache/skywalking/pull/6336/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=footer). Last update [fc23dab...850a065](https://codecov.io/gh/apache/skywalking/pull/6336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org