You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "mthmulders (via GitHub)" <gi...@apache.org> on 2025/03/21 09:03:32 UTC
[PR] Improve display of quote [maven-site]
mthmulders opened a new pull request, #738:
URL: https://github.com/apache/maven-site/pull/738
Following this checklist to help us incorporate your contribution quickly and easily:
- [X] Your pull request should address just one issue, without pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
- [X] Run `mvn site` and examine output in `target/site` directory.
Site will also be built on your pull request automatically and attached to GitHub Action result.
If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Before
After
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve display of quote [maven-site]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on PR #738:
URL: https://github.com/apache/maven-site/pull/738#issuecomment-2742780311
> Ha, the formatting was ruined by Spotless. Let me fight Spotless until it no longer ruins the display.
Yes that's why I gave up at one point :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve display of quote [maven-site]
Posted by "mthmulders (via GitHub)" <gi...@apache.org>.
mthmulders commented on PR #738:
URL: https://github.com/apache/maven-site/pull/738#issuecomment-2742756739
Ha, the formatting was ruined by Spotless. Let me fight Spotless until it no longer ruins the display.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve display of quote [maven-site]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama merged PR #738:
URL: https://github.com/apache/maven-site/pull/738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve display of quote [maven-site]
Posted by "mthmulders (via GitHub)" <gi...@apache.org>.
mthmulders commented on PR #738:
URL: https://github.com/apache/maven-site/pull/738#issuecomment-2742789201
I think it's good now. Spotless no longer flags violations and the `mdash` is now always on a new line, while the quote itself follows the page flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve display of quote [maven-site]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on PR #738:
URL: https://github.com/apache/maven-site/pull/738#issuecomment-2742815117
> I think it's good now. Spotless no longer flags violations and the `mdash` is now always on a new line, while the quote itself follows the page flow.
So it looks like on the "after" image?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org