[GitHub] [geode] dschneider-pivotal commented on a change in pull request #7219: feature/GEODE-9902: Modify ZUNIONSTORE and ZINTERSTORE storing methods

[GitBox <gi...@apache.org>]

dschneider-pivotal commented on a change in pull request #7219:
URL: https://github.com/apache/geode/pull/7219#discussion_r777692847



##########
File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSortedSet.java
##########
@@ -323,18 +339,47 @@ public long zinterstore(RegionProvider regionProvider, RedisKey key, List<ZKeyWe
           }
         }
       }
+
       if (addToSet) {
-        memberAdd(member, newScore);
+        OrderedSetEntry entry = interMembers.get(member);
+        if (entry == null) {
+          entry = new OrderedSetEntry(member, newScore);
+          interMembers.put(member, entry);
+          interScores.add(entry);
+        } else if (entry.getScore() != newScore) {
+          interScores.remove(entry);
+          entry.updateScore(newScore);
+          interScores.add(entry);
+        }
       }
     }
 
-    if (removeFromRegion()) {
-      regionProvider.getDataRegion().remove(key);
-    } else {
-      regionProvider.getLocalDataRegion().put(key, this);
+    return sortedSetOpStoreResult(regionProvider, key, interMembers, interScores);
+  }
+
+  static long sortedSetOpStoreResult(RegionProvider regionProvider, RedisKey destinationKey,

Review comment:
       add visibleForTesting




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org