You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Mandar Ambawane <ma...@freestoneinfotech.com> on 2019/11/20 15:01:47 UTC
Review Request 71794: ATLAS-3233 Relationships,
Export & Import : Issue with ACTIVE and DELETED relationship-def instances
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71794/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3233
https://issues.apache.org/jira/browse/ATLAS-3233
Repository: atlas
Description
-------
Here I have handled deletion part of relationship in case of import.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java a114d25
Diff: https://reviews.apache.org/r/71794/diff/1/
Testing
-------
Basic testing is done.
UT/ITs pending.
Thanks,
Mandar Ambawane
Re: Review Request 71794: ATLAS-3233 Relationships,
Export & Import : Issue with ACTIVE and DELETED relationship-def instances
Posted by Mandar Ambawane <ma...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71794/
-----------------------------------------------------------
(Updated Nov. 22, 2019, 12:53 p.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3233
https://issues.apache.org/jira/browse/ATLAS-3233
Repository: atlas
Description (updated)
-------
While importing, if we have 2 edges between two entities, one ACTIVE edge and one DELETED edge.
While creating such entities via import,
Existing code only checkes for the guids of the corresponding Vertices. If they are not matched then the relationship gets updated. Otherwise there was not updation of relationship.
Because of this, while importing entity, In import-json the status of relationship is changed from ACTIVE to DELETED still Relationship was not getting updated. (As its IN vertex and OUT vertex are unchanged.)
Now after this changes,
In importing process, relationshipStatus of incoming relationship is checked. and if its DELETED then we send relationship for deletion.(which is a soft deletion.)
This updation of relationshipStatus is used further in case of new relationship creation (whose status is ACTIVE in importing process)
Therefore only by deleting existing relationship, we can handle this issue.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java a114d25
Diff: https://reviews.apache.org/r/71794/diff/2/
Testing
-------
Basic testing is done.
UT/ITs pending.
Thanks,
Mandar Ambawane
Re: Review Request 71794: ATLAS-3233 Relationships,
Export & Import : Issue with ACTIVE and DELETED relationship-def instances
Posted by Mandar Ambawane <ma...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71794/
-----------------------------------------------------------
(Updated Nov. 22, 2019, 12:04 p.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Handled NPE.
Bugs: ATLAS-3233
https://issues.apache.org/jira/browse/ATLAS-3233
Repository: atlas
Description
-------
Here I have handled deletion part of relationship in case of import.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java a114d25
Diff: https://reviews.apache.org/r/71794/diff/2/
Changes: https://reviews.apache.org/r/71794/diff/1-2/
Testing
-------
Basic testing is done.
UT/ITs pending.
Thanks,
Mandar Ambawane