[jira] [Commented] (FLINK-9766) Incomplete/incorrect cleanup in RemoteInputChannelTest

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534243#comment-16534243 ] 

ASF GitHub Bot commented on FLINK-9766:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/6271

    [FLINK-9766][network][tests] fix cleanup in RemoteInputChannelTest

    ## What is the purpose of the change
    
    If an assertion in the tests of `RemoteInputChannelTest` fails and as a result the cleanup fails, in most tests the original assertion was swallowed making it hard to debug.
    
    Furthermore, `#testConcurrentRecycleAndRelease2()` does even not clean up at all
    if successful.
    
    ## Brief change log
    
    - add a helper method to unify (correct) cleanup so that if an exception is thrown in the `finally` block, it will be added as a suppressed exception
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
      - The S3 file system connector: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **not applicable**


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-9766

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6271.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6271
    
----
commit 0b623b66399915d43f29245da148fed63bf940bf
Author: Nico Kruber <ni...@...>
Date:   2018-07-05T13:49:15Z

    [FLINK-9766][network][tests] fix cleanup in RemoteInputChannelTest
    
    If an assertion in the test fails and as a result the cleanup fails, in most
    tests the original assertion was swallowed making it hard to debug.
    
    Furthermore, #testConcurrentRecycleAndRelease2() does even not clean up at all
    if successful.

----


> Incomplete/incorrect cleanup in RemoteInputChannelTest
> ------------------------------------------------------
>
>                 Key: FLINK-9766
>                 URL: https://issues.apache.org/jira/browse/FLINK-9766
>             Project: Flink
>          Issue Type: Bug
>          Components: Network, Tests
>    Affects Versions: 1.4.0, 1.5.0, 1.4.1, 1.4.2, 1.5.1
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.5.2, 1.6.0
>
>
> If an assertion in the tests fails and as a result the cleanup code wrapped into a {{finally}} block also fails, in most tests the original assertion was swallowed making it hard to debug
> in the successful case.
> Furthermore, {{testConcurrentRecycleAndRelease2()}} does even not clean up at all if successful.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)