You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/12 03:25:05 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #37854: [SPARK-40406][CORE] Change default logging to stderr to consistent with the behavior of log4j1
LuciferYang opened a new pull request, #37854:
URL: https://github.com/apache/spark/pull/37854
### What changes were proposed in this pull request?
As @Kimahriman mentioned, the default logging now goes to stdout instead of stderr, so this pr change it back to stderr.
### Why are the changes needed?
Keep consistent with the behavior of log4j1.
Ref to
https://github.com/apache/spark/blob/78a5825fe266c0884d2dd18cbca9625fa258d7f7/core/src/main/resources/org/apache/spark/log4j-defaults.properties#L18-L23
and the `log4j2.properties.template` also points to `SYSTEM_ERR`.
https://github.com/apache/spark/blob/78d492c1b153240dddc636ec6002e7bfc6b94b3b/core/src/main/resources/org/apache/spark/log4j2-defaults.properties#L19-L26
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GitHub Actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya closed pull request #37854: [SPARK-40406][CORE] Change default logging to stderr to consistent with the behavior of log4j1
Posted by GitBox <gi...@apache.org>.
viirya closed pull request #37854: [SPARK-40406][CORE] Change default logging to stderr to consistent with the behavior of log4j1
URL: https://github.com/apache/spark/pull/37854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #37854: [SPARK-40406][CORE] Change default logging to stderr to consistent with the behavior of log4j1
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #37854:
URL: https://github.com/apache/spark/pull/37854#issuecomment-1244879425
Thanks for fixing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37854: [SPARK-40406][CORE] Change default logging to stderr to consistent with the behavior of log4j1
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37854:
URL: https://github.com/apache/spark/pull/37854#issuecomment-1244906955
thanks @HyukjinKwon @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #37854: [SPARK-40406][CORE] Change default logging to stderr to consistent with the behavior of log4j1
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #37854:
URL: https://github.com/apache/spark/pull/37854#issuecomment-1244902461
Thanks. Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37854: [SPARK-40406][CORE] Change default logging to stderr to consistent with the behavior of log4j1
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37854:
URL: https://github.com/apache/spark/pull/37854#issuecomment-1244872616
friendly ping @srowen @HyukjinKwon @dongjoon-hyun @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org