You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org> on 2005/08/26 00:31:08 UTC

[jira] Created: (GERONIMO-918) Change service-ref to use single definition of "port"

Change service-ref to use single definition of "port"
-----------------------------------------------------

         Key: GERONIMO-918
         URL: http://issues.apache.org/jira/browse/GERONIMO-918
     Project: Geronimo
        Type: Bug
  Components: deployment, webservices  
    Versions: 1.0-M4    
    Reporter: Aaron Mulder
 Assigned to: Aaron Mulder 
     Fix For: 1.0-M5


Currently a web service reference has two elements named "port" that are slightly different.  One has all the same stuff as the other, plus one extra element.  This should be changed so both "port" elements are identical and one of them has an enclosing element containing the "port" and the extra element.

I think part of the issue is that both "port" elements are defined inline, and should instead refer to a separate portType.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (GERONIMO-918) Change service-ref to use single definition of "port"

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-918?page=all ]
     
David Jencks closed GERONIMO-918:
---------------------------------

    Resolution: Fixed

> Change service-ref to use single definition of "port"
> -----------------------------------------------------
>
>          Key: GERONIMO-918
>          URL: http://issues.apache.org/jira/browse/GERONIMO-918
>      Project: Geronimo
>         Type: Bug
>   Components: deployment, webservices
>     Versions: 1.0-M4
>     Reporter: Aaron Mulder
>     Assignee: David Jencks
>      Fix For: 1.0

>
> Currently a web service reference has two elements named "port" that are slightly different.  One has all the same stuff as the other, plus one extra element.  This should be changed so both "port" elements are identical and one of them has an enclosing element containing the "port" and the extra element.
> I think part of the issue is that both "port" elements are defined inline, and should instead refer to a separate portType.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (GERONIMO-918) Change service-ref to use single definition of "port"

Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-918?page=all ]

Aaron Mulder reassigned GERONIMO-918:
-------------------------------------

    Assign To: David Jencks  (was: Aaron Mulder)

> Change service-ref to use single definition of "port"
> -----------------------------------------------------
>
>          Key: GERONIMO-918
>          URL: http://issues.apache.org/jira/browse/GERONIMO-918
>      Project: Geronimo
>         Type: Bug
>   Components: deployment, webservices
>     Versions: 1.0-M4
>     Reporter: Aaron Mulder
>     Assignee: David Jencks
>      Fix For: 1.0-M5

>
> Currently a web service reference has two elements named "port" that are slightly different.  One has all the same stuff as the other, plus one extra element.  This should be changed so both "port" elements are identical and one of them has an enclosing element containing the "port" and the extra element.
> I think part of the issue is that both "port" elements are defined inline, and should instead refer to a separate portType.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (GERONIMO-918) Change service-ref to use single definition of "port"

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-918?page=comments#action_12320065 ] 

David Jencks commented on GERONIMO-918:
---------------------------------------

the tck plans are the only ones that use this element that I know of.

> Change service-ref to use single definition of "port"
> -----------------------------------------------------
>
>          Key: GERONIMO-918
>          URL: http://issues.apache.org/jira/browse/GERONIMO-918
>      Project: Geronimo
>         Type: Bug
>   Components: deployment, webservices
>     Versions: 1.0-M4
>     Reporter: Aaron Mulder
>     Assignee: Aaron Mulder
>      Fix For: 1.0-M5

>
> Currently a web service reference has two elements named "port" that are slightly different.  One has all the same stuff as the other, plus one extra element.  This should be changed so both "port" elements are identical and one of them has an enclosing element containing the "port" and the extra element.
> I think part of the issue is that both "port" elements are defined inline, and should instead refer to a separate portType.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (GERONIMO-918) Change service-ref to use single definition of "port"

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-918?page=comments#action_12329854 ] 

David Jencks commented on GERONIMO-918:
---------------------------------------

Fixed in head:
Sending        modules/axis-builder/src/java/org/apache/geronimo/axis/builder/AxisBuilder.java
Sending        modules/naming-builder/src/schema/geronimo-naming.xsd
Transmitting file data ..
Committed revision 290169.

tck plans fixed.  I think this should go into M5 but I won't have time to merge until at least tuesday afternoon.  Anyone who wants to merge, please go ahead.

> Change service-ref to use single definition of "port"
> -----------------------------------------------------
>
>          Key: GERONIMO-918
>          URL: http://issues.apache.org/jira/browse/GERONIMO-918
>      Project: Geronimo
>         Type: Bug
>   Components: deployment, webservices
>     Versions: 1.0-M4
>     Reporter: Aaron Mulder
>     Assignee: David Jencks
>      Fix For: 1.0-M5

>
> Currently a web service reference has two elements named "port" that are slightly different.  One has all the same stuff as the other, plus one extra element.  This should be changed so both "port" elements are identical and one of them has an enclosing element containing the "port" and the extra element.
> I think part of the issue is that both "port" elements are defined inline, and should instead refer to a separate portType.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (GERONIMO-918) Change service-ref to use single definition of "port"

Posted by "David Blevins (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-918?page=all ]

David Blevins updated GERONIMO-918:
-----------------------------------

    Fix Version: 1.0
                     (was: 1.0-M5)

> Change service-ref to use single definition of "port"
> -----------------------------------------------------
>
>          Key: GERONIMO-918
>          URL: http://issues.apache.org/jira/browse/GERONIMO-918
>      Project: Geronimo
>         Type: Bug
>   Components: deployment, webservices
>     Versions: 1.0-M4
>     Reporter: Aaron Mulder
>     Assignee: David Jencks
>      Fix For: 1.0

>
> Currently a web service reference has two elements named "port" that are slightly different.  One has all the same stuff as the other, plus one extra element.  This should be changed so both "port" elements are identical and one of them has an enclosing element containing the "port" and the extra element.
> I think part of the issue is that both "port" elements are defined inline, and should instead refer to a separate portType.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (GERONIMO-918) Change service-ref to use single definition of "port"

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-918?page=comments#action_12320058 ] 

David Jencks commented on GERONIMO-918:
---------------------------------------

I don't like what you propose.  I'd be ok with changing the port-completionType element to be named port-completion rather than port.  WDYT?  Will you locate and fix all the plans that are affected by this change?

> Change service-ref to use single definition of "port"
> -----------------------------------------------------
>
>          Key: GERONIMO-918
>          URL: http://issues.apache.org/jira/browse/GERONIMO-918
>      Project: Geronimo
>         Type: Bug
>   Components: deployment, webservices
>     Versions: 1.0-M4
>     Reporter: Aaron Mulder
>     Assignee: Aaron Mulder
>      Fix For: 1.0-M5

>
> Currently a web service reference has two elements named "port" that are slightly different.  One has all the same stuff as the other, plus one extra element.  This should be changed so both "port" elements are identical and one of them has an enclosing element containing the "port" and the extra element.
> I think part of the issue is that both "port" elements are defined inline, and should instead refer to a separate portType.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (GERONIMO-918) Change service-ref to use single definition of "port"

Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-918?page=comments#action_12320062 ] 

Aaron Mulder commented on GERONIMO-918:
---------------------------------------

My first choice would be what I originally proposed because all the elements are the same and hold essentially the same chunks of information, as I understand it.  However, I'm totally unwilling to defend this against any opposition, I just really don't like two container elements with the same name holding different things.  If you'd be happier with your proposal, that's fine by me.

I see "a handful of" TCK plans with a service-completion element.  I will update those.  Are you aware of any other plans that would need it?

> Change service-ref to use single definition of "port"
> -----------------------------------------------------
>
>          Key: GERONIMO-918
>          URL: http://issues.apache.org/jira/browse/GERONIMO-918
>      Project: Geronimo
>         Type: Bug
>   Components: deployment, webservices
>     Versions: 1.0-M4
>     Reporter: Aaron Mulder
>     Assignee: Aaron Mulder
>      Fix For: 1.0-M5

>
> Currently a web service reference has two elements named "port" that are slightly different.  One has all the same stuff as the other, plus one extra element.  This should be changed so both "port" elements are identical and one of them has an enclosing element containing the "port" and the extra element.
> I think part of the issue is that both "port" elements are defined inline, and should instead refer to a separate portType.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira