You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Mark Wang <ma...@gmail.com> on 2015/07/06 20:02:31 UTC
Re: Review Request 35286: Rename Option::get(const T& _t) to
getOrElse() and refactor original functions (libprocess)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35286/
-----------------------------------------------------------
(Updated July 6, 2015, 6:02 p.m.)
Review request for mesos and Joris Van Remoortere.
Bugs: MESOS-2800
https://issues.apache.org/jira/browse/MESOS-2800
Repository: mesos
Description
-------
Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (libprocess)
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp 883776a6d87f3f14d04e2d574b0e0baa469af579
3rdparty/libprocess/src/subprocess.cpp 5b41f0d88fcab93d51d5c503f69faccedc210868
Diff: https://reviews.apache.org/r/35286/diff/
Testing
-------
make check
Thanks,
Mark Wang
Re: Review Request 35286: Rename Option::get(const T& _t) to
getOrElse() and refactor original functions (libprocess)
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35286/#review90546
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On July 6, 2015, 6:46 p.m., Mark Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35286/
> -----------------------------------------------------------
>
> (Updated July 6, 2015, 6:46 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-2800
> https://issues.apache.org/jira/browse/MESOS-2800
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (libprocess)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 883776a6d87f3f14d04e2d574b0e0baa469af579
>
> Diff: https://reviews.apache.org/r/35286/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Mark Wang
>
>
Re: Review Request 35286: Rename Option::get(const T& _t) to
getOrElse() and refactor original functions (libprocess)
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35286/#review90537
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On July 6, 2015, 6:46 p.m., Mark Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35286/
> -----------------------------------------------------------
>
> (Updated July 6, 2015, 6:46 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-2800
> https://issues.apache.org/jira/browse/MESOS-2800
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (libprocess)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 883776a6d87f3f14d04e2d574b0e0baa469af579
>
> Diff: https://reviews.apache.org/r/35286/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Mark Wang
>
>
Re: Review Request 35286: Rename Option::get(const T& _t) to
getOrElse() and refactor original functions (libprocess)
Posted by Mark Wang <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35286/
-----------------------------------------------------------
(Updated July 6, 2015, 6:46 p.m.)
Review request for mesos and Joris Van Remoortere.
Bugs: MESOS-2800
https://issues.apache.org/jira/browse/MESOS-2800
Repository: mesos
Description
-------
Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (libprocess)
Diffs
-----
3rdparty/libprocess/src/process.cpp 883776a6d87f3f14d04e2d574b0e0baa469af579
Diff: https://reviews.apache.org/r/35286/diff/
Testing
-------
make check
Thanks,
Mark Wang
Re: Review Request 35286: Rename Option::get(const T& _t) to
getOrElse() and refactor original functions (libprocess)
Posted by Mark Wang <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35286/
-----------------------------------------------------------
(Updated July 6, 2015, 6:45 p.m.)
Review request for mesos and Joris Van Remoortere.
Bugs: MESOS-2800
https://issues.apache.org/jira/browse/MESOS-2800
Repository: mesos
Description
-------
Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (libprocess)
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp 883776a6d87f3f14d04e2d574b0e0baa469af579
Diff: https://reviews.apache.org/r/35286/diff/
Testing
-------
make check
Thanks,
Mark Wang
Re: Review Request 35286: Rename Option::get(const T& _t) to
getOrElse() and refactor original functions (libprocess)
Posted by Mark Wang <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35286/
-----------------------------------------------------------
(Updated July 6, 2015, 6:33 p.m.)
Review request for mesos and Joris Van Remoortere.
Bugs: MESOS-2800
https://issues.apache.org/jira/browse/MESOS-2800
Repository: mesos
Description
-------
Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (libprocess)
Diffs
-----
3rdparty/libprocess/src/process.cpp 883776a6d87f3f14d04e2d574b0e0baa469af579
3rdparty/libprocess/src/subprocess.cpp 5b41f0d88fcab93d51d5c503f69faccedc210868
Diff: https://reviews.apache.org/r/35286/diff/
Testing
-------
make check
Thanks,
Mark Wang