[GitHub] [hbase] Apache9 commented on pull request #4942: HBASE-27547 Close store file readers after region warmup

[GitBox <gi...@apache.org>]

Apache9 commented on PR #4942:
URL: https://github.com/apache/hbase/pull/4942#issuecomment-1378208887

   > > > OK, it is https://issues.apache.org/jira/browse/HBASE-15441.
   > > > I think for warmup, the region should be opened as read only so it should not write any markers to WAL.
   > > > And [HBASE-15441](https://issues.apache.org/jira/browse/HBASE-15441) should have been included in 1.4.13, so this should not be the root cause of too many FDs?
   > > > WDYT? @EungsopYoo
   > > > Thanks.
   > > 
   > > 
   > > Right. In 1.4.13, the warmed up region is not closed too. It's not the cause. https://github.com/apache/hbase/blob/rel/1.4.13/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L7163-L7164
   > 
   > I misunderstood your question.
   > 
   > There are two points. The first is the leakage of open FDs during region moving(due to warmup), and the second is that HBase 2.4 opens much more FDs than HBase 1.4.
   > 
   > In this PR, I fixed the first. The second is still in question.
   
   So I mean we should try to restore the old behavior, to close the warm up region? Now we support open a region in read only mode so when closing the region, we will not write any wal out, so it will not mess up wal splitting.
   WDYT?
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org