You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2023/01/04 08:27:07 UTC
[GitHub] [incubator-devlake] likyh opened a new pull request, #4099: fix: support jenkins v100 upgrade
likyh opened a new pull request, #4099:
URL: https://github.com/apache/incubator-devlake/pull/4099
### Summary
Jenkins v100 needn't scope. So I create a V100 bp with jenkins try to upgrade it and fix some some bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mintsweet commented on a diff in pull request #4099: fix: support jenkins v100 upgrade
Posted by GitBox <gi...@apache.org>.
mintsweet commented on code in PR #4099:
URL: https://github.com/apache/incubator-devlake/pull/4099#discussion_r1061237555
##########
config-ui/src/error/components/bp-upgrade/use-bp-upgrade.ts:
##########
@@ -118,7 +118,9 @@ export const useBPUpgrade = ({ id, onResetError }: UseBPUpgradeProps) => {
const upgradeConnection = async (connection: any) => {
const { plugin, connectionId } = connection;
- const scopeList = await Promise.all(connection.scope.map((sc: any) => upgradeScope(plugin, connectionId, sc)));
+ const scopeList = connection.scope
Review Comment:
`const scopeList = await Promise.all((connection.scope ?? []).map((sc: any) => upgradeScope(plugin, connectionId, sc)));`
##########
config-ui/src/pages/blueprint/detail/panel/configuration.tsx:
##########
@@ -64,7 +64,7 @@ export const Configuration = ({ blueprint, operating, onUpdate, onRefresh }: Pro
name: plugin.name,
connectionId: cs.connectionId,
entities: plugin.entities,
- selectedEntites: cs.scopes[0].entities,
+ selectedEntites: cs.scopes.length > 0 ? cs.scopes[0].entities : [],
Review Comment:
`cs.scopes?.[0].entities ?? []`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on a diff in pull request #4099: fix: support jenkins v100 upgrade
Posted by GitBox <gi...@apache.org>.
likyh commented on code in PR #4099:
URL: https://github.com/apache/incubator-devlake/pull/4099#discussion_r1061241335
##########
config-ui/src/error/components/bp-upgrade/use-bp-upgrade.ts:
##########
@@ -118,7 +118,9 @@ export const useBPUpgrade = ({ id, onResetError }: UseBPUpgradeProps) => {
const upgradeConnection = async (connection: any) => {
const { plugin, connectionId } = connection;
- const scopeList = await Promise.all(connection.scope.map((sc: any) => upgradeScope(plugin, connectionId, sc)));
+ const scopeList = connection.scope
Review Comment:
fixed
##########
config-ui/src/pages/blueprint/detail/panel/configuration.tsx:
##########
@@ -64,7 +64,7 @@ export const Configuration = ({ blueprint, operating, onUpdate, onRefresh }: Pro
name: plugin.name,
connectionId: cs.connectionId,
entities: plugin.entities,
- selectedEntites: cs.scopes[0].entities,
+ selectedEntites: cs.scopes.length > 0 ? cs.scopes[0].entities : [],
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on a diff in pull request #4099: fix: support jenkins v100 upgrade
Posted by GitBox <gi...@apache.org>.
likyh commented on code in PR #4099:
URL: https://github.com/apache/incubator-devlake/pull/4099#discussion_r1061239805
##########
config-ui/src/pages/blueprint/detail/panel/configuration.tsx:
##########
@@ -64,7 +64,7 @@ export const Configuration = ({ blueprint, operating, onUpdate, onRefresh }: Pro
name: plugin.name,
connectionId: cs.connectionId,
entities: plugin.entities,
- selectedEntites: cs.scopes[0].entities,
+ selectedEntites: cs.scopes.length > 0 ? cs.scopes[0].entities : [],
Review Comment:
kind of difficult to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 merged pull request #4099: fix: support jenkins v100 upgrade
Posted by GitBox <gi...@apache.org>.
warren830 merged PR #4099:
URL: https://github.com/apache/incubator-devlake/pull/4099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org