You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/12/08 23:10:33 UTC
Review Request 28812: Added a TODO in the master for an allocator bug.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28812/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos-git
Description
-------
The existing comment is not accurate, given MESOS-621.
Diffs
-----
src/master/master.cpp b910665caa437f3f92c5abc14c0b8eab9a1ec5f3
Diff: https://reviews.apache.org/r/28812/diff/
Testing
-------
N/A
Thanks,
Ben Mahler
Re: Review Request 28812: Added a TODO in the master for an allocator
bug.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28812/#review64292
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On Dec. 8, 2014, 2:10 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28812/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 2:10 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The existing comment is not accurate, given MESOS-621.
>
>
> Diffs
> -----
>
> src/master/master.cpp b910665caa437f3f92c5abc14c0b8eab9a1ec5f3
>
> Diff: https://reviews.apache.org/r/28812/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 28812: Added a TODO in the master for an allocator
bug.
Posted by Ben Mahler <be...@gmail.com>.
> On Dec. 8, 2014, 10:48 p.m., Jie Yu wrote:
> > src/master/master.cpp, lines 4428-4431
> > <https://reviews.apache.org/r/28812/diff/1/?file=785774#file785774line4428>
> >
> > I got confused here. I need to dig into the ticket to understand what's going on here. Also, this does not like a TODO to me (since the allocator will be in consistent state after 'removeTask' is called below), maybe a NOTE is more appropriate?
Re-wrote the existing comment (since it was wrong anyway), let me know if it makes more sense now Jie!
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28812/#review64296
-----------------------------------------------------------
On Dec. 11, 2014, 1:45 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28812/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 1:45 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The existing comment is not accurate, given MESOS-621.
>
>
> Diffs
> -----
>
> src/master/master.cpp 1cf2074b78e260bcccf96f4383bc4747b1e75063
>
> Diff: https://reviews.apache.org/r/28812/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 28812: Added a TODO in the master for an allocator
bug.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28812/#review64296
-----------------------------------------------------------
src/master/master.cpp
<https://reviews.apache.org/r/28812/#comment106930>
I got confused here. I need to dig into the ticket to understand what's going on here. Also, this does not like a TODO to me (since the allocator will be in consistent state after 'removeTask' is called below), maybe a NOTE is more appropriate?
- Jie Yu
On Dec. 8, 2014, 10:10 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28812/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 10:10 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The existing comment is not accurate, given MESOS-621.
>
>
> Diffs
> -----
>
> src/master/master.cpp b910665caa437f3f92c5abc14c0b8eab9a1ec5f3
>
> Diff: https://reviews.apache.org/r/28812/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 28812: Added a TODO in the master for an allocator
bug.
Posted by Ben Mahler <be...@gmail.com>.
> On Dec. 11, 2014, 7:57 p.m., Jie Yu wrote:
> > src/master/master.cpp, lines 4537-4539
> > <https://reviews.apache.org/r/28812/diff/2/?file=788903#file788903line4537>
> >
> > I think your comments are fine. The missleading part is the function "recoverResources". It actually performs two things:
> > 1) put resources back to slave.avalable so that those resources can be allocated to others
> > 2) update sorters so that frameworks/roles no longer get charged for those resources
> >
> > To me, (1) is the "recover" part. The fact that you wanna call "recoverResources" below in this function is actually for (2).
Yeah, what you describe is the MESOS-621 issue. Ok, I'll update this to be a bit more descriptive, and to reference the ticket. Thanks!
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28812/#review64782
-----------------------------------------------------------
On Dec. 11, 2014, 1:45 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28812/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 1:45 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The existing comment is not accurate, given MESOS-621.
>
>
> Diffs
> -----
>
> src/master/master.cpp 1cf2074b78e260bcccf96f4383bc4747b1e75063
>
> Diff: https://reviews.apache.org/r/28812/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 28812: Added a TODO in the master for an allocator
bug.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28812/#review64782
-----------------------------------------------------------
Ship it!
src/master/master.cpp
<https://reviews.apache.org/r/28812/#comment107549>
I think your comments are fine. The missleading part is the function "recoverResources". It actually performs two things:
1) put resources back to slave.avalable so that those resources can be allocated to others
2) update sorters so that frameworks/roles no longer get charged for those resources
To me, (1) is the "recover" part. The fact that you wanna call "recoverResources" below in this function is actually for (2).
- Jie Yu
On Dec. 11, 2014, 1:45 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28812/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 1:45 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The existing comment is not accurate, given MESOS-621.
>
>
> Diffs
> -----
>
> src/master/master.cpp 1cf2074b78e260bcccf96f4383bc4747b1e75063
>
> Diff: https://reviews.apache.org/r/28812/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 28812: Added a TODO in the master for an allocator
bug.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28812/
-----------------------------------------------------------
(Updated Dec. 11, 2014, 1:45 a.m.)
Review request for mesos and Jie Yu.
Changes
-------
Re-wrote the comment.
Repository: mesos-git
Description
-------
The existing comment is not accurate, given MESOS-621.
Diffs (updated)
-----
src/master/master.cpp 1cf2074b78e260bcccf96f4383bc4747b1e75063
Diff: https://reviews.apache.org/r/28812/diff/
Testing
-------
N/A
Thanks,
Ben Mahler