You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "imbajin (via GitHub)" <gi...@apache.org> on 2026/10/10 05:31:25 UTC
[PR] fix(loader): preserve launcher arguments [hugegraph-toolchain]
imbajin opened a new pull request, #800:
URL: https://github.com/apache/hugegraph-toolchain/pull/800
## Purpose of the PR
The ordinary Loader launcher splits installation paths and user arguments containing spaces, expands literal globs, and drops empty arguments. The Java process now receives the intended classpath and original argument boundaries.
Reported during [master integration testing](https://github.com/hugegraph/hugegraph-toolchain/pull/47#issuecomment-6064536763).
## Main Changes
- Quote installation and library paths, and pass the classpath as one Java argument.
- Forward user arguments with `"$@"` while preserving existing JVM option handling and classpath order.
- Run ordinary launcher argument regressions alongside the Spark launcher checks in Loader CI.
## Verifying these changes
- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
- [ ] Already covered by existing tests.
- [x] Need tests and can be verified as follows:
- `python3 hugegraph-loader/src/test/python/test_loader_launcher.py` and the existing Spark launcher tests pass.
- The original script fails argument regressions; a Java 17 entry point confirms spaces, empty arguments, and literal globs under both Bash and POSIX sh.
- Packaged Loader import and PR CI remain to be verified.
## Does this PR potentially affect the following parts?
- [ ] Nope
- [ ] Dependencies (add/update license info)
- [ ] Modify configurations
- [ ] The public API
- [x] Other affects: ordinary Loader process arguments
## Documentation Status
- [ ] `Doc - TODO`
- [ ] `Doc - Done`
- [x] `Doc - No Need`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(loader): preserve launcher arguments [hugegraph-toolchain]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #800:
URL: https://github.com/apache/hugegraph-toolchain/pull/800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(loader): preserve launcher arguments [hugegraph-toolchain]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #800:
URL: https://github.com/apache/hugegraph-toolchain/pull/800#issuecomment-6094305952
## [Codecov](https://app.codecov.io/gh/apache/hugegraph-toolchain/pull/800?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 55.48%. Comparing base ([`e669922`](https://app.codecov.io/gh/apache/hugegraph-toolchain/commit/e66992215557958d6a41bdfb353b2138a0ca5570?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8ba764d`](https://app.codecov.io/gh/apache/hugegraph-toolchain/commit/8ba764d999f7132cdd68d2fa5866e3d13e850867?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #800 +/- ##
=============================================
+ Coverage 44.26% 55.48% +11.22%
+ Complexity 3260 1096 -2164
=============================================
Files 377 111 -266
Lines 22289 6059 -16230
Branches 2974 808 -2166
=============================================
- Hits 9866 3362 -6504
+ Misses 11360 2430 -8930
+ Partials 1063 267 -796
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/hugegraph-toolchain/pull/800?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org