You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Ernie Allen <ea...@redhat.com> on 2013/02/19 18:36:55 UTC
Re: Review Request: QPID-4559 Check the if_empty and if_unused flags when
deleting a queue with deleteObject()
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9510/
-----------------------------------------------------------
(Updated Feb. 19, 2013, 5:36 p.m.)
Review request for qpid.
Summary (updated)
-----------------
QPID-4559 Check the if_empty and if_unused flags when deleting a queue with deleteObject()
Description
-------
Adds a check() method to the broker and passes it to queueDelete to inspect the if_unused and if_empty flags.
This addresses bug QPID-4559.
https://issues.apache.org/jira/browse/QPID-4559
Diffs
-----
/trunk/qpid/cpp/src/qpid/broker/Broker.h 1447816
/trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1447816
Diff: https://reviews.apache.org/r/9510/diff/
Testing
-------
unit tests: created queue, added messages, deleted queue with and without flags and with and without messages and connections
Thanks,
Ernie Allen
Re: Review Request: QPID-4559 Check the if_empty and if_unused flags when
deleting a queue with deleteObject()
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9510/#review16859
-----------------------------------------------------------
Ship it!
Ship It!
- Kenneth Giusti
On Feb. 20, 2013, 7:25 p.m., Ernie Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9510/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2013, 7:25 p.m.)
>
>
> Review request for qpid and Ted Ross.
>
>
> Description
> -------
>
> Adds a check() method to the broker and passes it to queueDelete to inspect the if_unused and if_empty flags.
>
>
> This addresses bug QPID-4559.
> https://issues.apache.org/jira/browse/QPID-4559
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/broker/Broker.h 1447816
> /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1447816
>
> Diff: https://reviews.apache.org/r/9510/diff/
>
>
> Testing
> -------
>
> unit tests: created queue, added messages, deleted queue with and without flags and with and without messages and connections
>
>
> Thanks,
>
> Ernie Allen
>
>
Re: Review Request: QPID-4559 Check the if_empty and if_unused flags when
deleting a queue with deleteObject()
Posted by Ernie Allen <ea...@redhat.com>.
> On Feb. 20, 2013, 8:29 p.m., Kenneth Giusti wrote:
> > These broker side changes look good, however, on trunk, qpid-config doesn't seem to pass along the if_empty or if_unused flags.
> >
> > Specifically, when I:
> >
> > qpid-config --force del queue ken
> >
> > I get this on the broker log:
> >
> > 2013-02-20 15:19:39 [Management] debug RECV MethodRequest (v2) class=org.apache.qpid.broker:broker method=delete replyTo=qmf.default.topic/direct.3dcd54bb-44d2-4e26-b031-0e1c75a0851d objId=0-0-0--0(org.apache.qpid.broker:broker:amqp-broker) inArgs={name:ken, type:queue}
> > 2013-02-20 15:19:39 [Broker] debug Broker::delete(queue, ken,{})
> >
> > That empty map in the last log message should include those two flags, but they're not present.
> >
> > Are changes needed in qpid-config to pass those flags to delete?
> >
There is a separate bz that addresses the qpid-config problem of not passing the if_empty and if_unused flags. It will be released at the same time as this fix.
- Ernie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9510/#review16790
-----------------------------------------------------------
On Feb. 20, 2013, 7:25 p.m., Ernie Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9510/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2013, 7:25 p.m.)
>
>
> Review request for qpid and Ted Ross.
>
>
> Description
> -------
>
> Adds a check() method to the broker and passes it to queueDelete to inspect the if_unused and if_empty flags.
>
>
> This addresses bug QPID-4559.
> https://issues.apache.org/jira/browse/QPID-4559
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/broker/Broker.h 1447816
> /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1447816
>
> Diff: https://reviews.apache.org/r/9510/diff/
>
>
> Testing
> -------
>
> unit tests: created queue, added messages, deleted queue with and without flags and with and without messages and connections
>
>
> Thanks,
>
> Ernie Allen
>
>
Re: Review Request: QPID-4559 Check the if_empty and if_unused flags when
deleting a queue with deleteObject()
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9510/#review16790
-----------------------------------------------------------
These broker side changes look good, however, on trunk, qpid-config doesn't seem to pass along the if_empty or if_unused flags.
Specifically, when I:
qpid-config --force del queue ken
I get this on the broker log:
2013-02-20 15:19:39 [Management] debug RECV MethodRequest (v2) class=org.apache.qpid.broker:broker method=delete replyTo=qmf.default.topic/direct.3dcd54bb-44d2-4e26-b031-0e1c75a0851d objId=0-0-0--0(org.apache.qpid.broker:broker:amqp-broker) inArgs={name:ken, type:queue}
2013-02-20 15:19:39 [Broker] debug Broker::delete(queue, ken,{})
That empty map in the last log message should include those two flags, but they're not present.
Are changes needed in qpid-config to pass those flags to delete?
- Kenneth Giusti
On Feb. 20, 2013, 7:25 p.m., Ernie Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9510/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2013, 7:25 p.m.)
>
>
> Review request for qpid and Ted Ross.
>
>
> Description
> -------
>
> Adds a check() method to the broker and passes it to queueDelete to inspect the if_unused and if_empty flags.
>
>
> This addresses bug QPID-4559.
> https://issues.apache.org/jira/browse/QPID-4559
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/broker/Broker.h 1447816
> /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1447816
>
> Diff: https://reviews.apache.org/r/9510/diff/
>
>
> Testing
> -------
>
> unit tests: created queue, added messages, deleted queue with and without flags and with and without messages and connections
>
>
> Thanks,
>
> Ernie Allen
>
>
Re: Review Request: QPID-4559 Check the if_empty and if_unused flags when
deleting a queue with deleteObject()
Posted by Ernie Allen <ea...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9510/
-----------------------------------------------------------
(Updated Feb. 20, 2013, 7:25 p.m.)
Review request for qpid and Ted Ross.
Changes
-------
Initialized ifUnused to false.
Description
-------
Adds a check() method to the broker and passes it to queueDelete to inspect the if_unused and if_empty flags.
This addresses bug QPID-4559.
https://issues.apache.org/jira/browse/QPID-4559
Diffs (updated)
-----
/trunk/qpid/cpp/src/qpid/broker/Broker.h 1447816
/trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1447816
Diff: https://reviews.apache.org/r/9510/diff/
Testing
-------
unit tests: created queue, added messages, deleted queue with and without flags and with and without messages and connections
Thanks,
Ernie Allen
Re: Review Request: QPID-4559 Check the if_empty and if_unused flags when
deleting a queue with deleteObject()
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9510/#review16780
-----------------------------------------------------------
/trunk/qpid/cpp/src/qpid/broker/Broker.cpp
<https://reviews.apache.org/r/9510/#comment35656>
is ifUnused uninitialized here?
- Kenneth Giusti
On Feb. 19, 2013, 6:14 p.m., Ernie Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9510/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2013, 6:14 p.m.)
>
>
> Review request for qpid and Ted Ross.
>
>
> Description
> -------
>
> Adds a check() method to the broker and passes it to queueDelete to inspect the if_unused and if_empty flags.
>
>
> This addresses bug QPID-4559.
> https://issues.apache.org/jira/browse/QPID-4559
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/broker/Broker.h 1447816
> /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1447816
>
> Diff: https://reviews.apache.org/r/9510/diff/
>
>
> Testing
> -------
>
> unit tests: created queue, added messages, deleted queue with and without flags and with and without messages and connections
>
>
> Thanks,
>
> Ernie Allen
>
>
Re: Review Request: QPID-4559 Check the if_empty and if_unused flags when
deleting a queue with deleteObject()
Posted by Ernie Allen <ea...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9510/
-----------------------------------------------------------
(Updated Feb. 19, 2013, 6:14 p.m.)
Review request for qpid and Ted Ross.
Description
-------
Adds a check() method to the broker and passes it to queueDelete to inspect the if_unused and if_empty flags.
This addresses bug QPID-4559.
https://issues.apache.org/jira/browse/QPID-4559
Diffs
-----
/trunk/qpid/cpp/src/qpid/broker/Broker.h 1447816
/trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1447816
Diff: https://reviews.apache.org/r/9510/diff/
Testing
-------
unit tests: created queue, added messages, deleted queue with and without flags and with and without messages and connections
Thanks,
Ernie Allen