You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mumrah (via GitHub)" <gi...@apache.org> on 2024/12/11 19:42:24 UTC
[PR] MINOR Auto-approve pr-reviewed workflow [kafka]
mumrah opened a new pull request, #18147:
URL: https://github.com/apache/kafka/pull/18147
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR Remove triage label in nightly job [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on PR #18147:
URL: https://github.com/apache/kafka/pull/18147#issuecomment-2554630777
It works 🎉 https://github.com/apache/kafka/actions/runs/12405547852/job/34632606547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR Auto-approve pr-reviewed workflow [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on PR #18147:
URL: https://github.com/apache/kafka/pull/18147#issuecomment-2539041773
@gharris1727 another followup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR Remove triage label in nightly job [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah merged PR #18147:
URL: https://github.com/apache/kafka/pull/18147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR Auto-approve pr-reviewed workflow [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on PR #18147:
URL: https://github.com/apache/kafka/pull/18147#issuecomment-2546061691
@chia7712 could you take a look at this? The workflow to remove the "triage" label isn't running automatically and this PR should fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR Auto-approve pr-reviewed workflow [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on PR #18147:
URL: https://github.com/apache/kafka/pull/18147#issuecomment-2546086336
Actually I'm realizing now this might not work. Since `pull_request_review` runs the workflow definition from the PR, it will require approval before running. However, for some reason the API call is failing on these approvals
```
$ gh api --method POST \
-H 'Accept: application/vnd.github+json' \
-H 'X-GitHub-Api-Version: 2022-11-28' \
/repos/apache/kafka/actions/runs/12356775485/approve
{
"message": "This run is not from a fork pull request",
"documentation_url": "https://docs.github.com/rest/actions/workflow-runs#approve-a-workflow-run-for-a-fork-pull-request",
"status": "403"
}
gh: This run is not from a fork pull request (HTTP 403)
```
I was able to approve the workflow in the UI, but not using the API. Maybe this is a bug in the `pull_request_review` event handling 🤷♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR Remove triage label in nightly job [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on PR #18147:
URL: https://github.com/apache/kafka/pull/18147#issuecomment-2546297965
Ok @chia7712, _now_ it's ready for review 😄. I rewrote this workflow to run as a cron job rather than trying to react to the `pull_request_review` event.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org