You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/02/23 07:22:46 UTC

[GitHub] [cordova-ios] erisu opened a new pull request #797: breaking: remove MediaPlaybackRequiresUserAction and update MediaTypesRequiringUserActionForPlayback to proper variable types

erisu opened a new pull request #797: breaking: remove MediaPlaybackRequiresUserAction and update MediaTypesRequiringUserActionForPlayback to proper variable types
URL: https://github.com/apache/cordova-ios/pull/797
 
 
   ### Motivation and Context
   
   `MediaPlaybackRequiresUserAction` was replaced with `MediaTypesRequiringUserActionForPlayback` in a previous PR. Since the `MediaTypesRequiringUserActionForPlayback` defaults will always exist in `defaults.xml`, `MediaPlaybackRequiresUserAction` will never be read. The old preference logic should actually be removed.
   
   Additionally, the old preference `MediaPlaybackRequiresUserAction`  accepted `boolean` values but the new `MediaTypesRequiringUserActionForPlayback` preference does not accept boolean. This needs to be corrected to accept proper value types.
   
   ### Description
   
   This PR removes all of `MediaPlaybackRequiresUserAction` logic except for the deprecated warning. The warning is used to provide users a migration step. It will be removed in a later release.
   
   This PR has also updated the native code to pass in the correct variable types for the new 
   `MediaTypesRequiringUserActionForPlayback` preference option.
   
   Example valid preference option with proper values are:
   
   ```
   <preference name="MediaTypesRequiringUserActionForPlayback" value="all" />
   <preference name="MediaTypesRequiringUserActionForPlayback" value="audio" />
   <preference name="MediaTypesRequiringUserActionForPlayback" value="video" />
   <preference name="MediaTypesRequiringUserActionForPlayback" value="none" />
   ```
   
   ### Testing
   
   - `npm t`
   - `cordova platform add`
   - `cordova build ios`
   - Run in simulator
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[GitHub] [cordova-ios] codecov-io commented on issue #797: breaking: remove MediaPlaybackRequiresUserAction and update MediaTypesRequiringUserActionForPlayback to proper variable types

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #797: breaking: remove MediaPlaybackRequiresUserAction and update MediaTypesRequiringUserActionForPlayback to proper variable types
URL: https://github.com/apache/cordova-ios/pull/797#issuecomment-590684814
 
 
   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/797?src=pr&el=h1) Report
   > Merging [#797](https://codecov.io/gh/apache/cordova-ios/pull/797?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/4ac155251e78b59ea74c91f29ab0353721dba475?src=pr&el=desc) will **decrease** coverage by `0.16%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/797/graphs/tree.svg?width=650&token=WomDD5jInz&height=150&src=pr)](https://codecov.io/gh/apache/cordova-ios/pull/797?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #797      +/-   ##
   =========================================
   - Coverage   74.36%   74.2%   -0.17%     
   =========================================
     Files          13      13              
     Lines        1845    1849       +4     
   =========================================
     Hits         1372    1372              
   - Misses        473     477       +4
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/797?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/797/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `82.05% <0%> (-0.73%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/797?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/797?src=pr&el=footer). Last update [4ac1552...d322947](https://codecov.io/gh/apache/cordova-ios/pull/797?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[GitHub] [cordova-ios] codecov-io edited a comment on issue #797: breaking: remove MediaPlaybackRequiresUserAction and update MediaTypesRequiringUserActionForPlayback to proper variable types

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #797: breaking: remove MediaPlaybackRequiresUserAction and update MediaTypesRequiringUserActionForPlayback to proper variable types
URL: https://github.com/apache/cordova-ios/pull/797#issuecomment-590684814
 
 
   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/797?src=pr&el=h1) Report
   > Merging [#797](https://codecov.io/gh/apache/cordova-ios/pull/797?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/df33c47274f35925a2dbc861a3ad4b4078e37aac?src=pr&el=desc) will **decrease** coverage by `0.16%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/797/graphs/tree.svg?width=650&token=WomDD5jInz&height=150&src=pr)](https://codecov.io/gh/apache/cordova-ios/pull/797?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #797      +/-   ##
   =========================================
   - Coverage   74.36%   74.2%   -0.17%     
   =========================================
     Files          13      13              
     Lines        1845    1849       +4     
   =========================================
     Hits         1372    1372              
   - Misses        473     477       +4
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/797?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/797/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `82.05% <0%> (-0.73%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/797?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/797?src=pr&el=footer). Last update [df33c47...cb8f965](https://codecov.io/gh/apache/cordova-ios/pull/797?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[GitHub] [cordova-ios] erisu merged pull request #797: breaking: remove MediaPlaybackRequiresUserAction and update MediaTypesRequiringUserActionForPlayback to proper variable types

Posted by GitBox <gi...@apache.org>.
erisu merged pull request #797: breaking: remove MediaPlaybackRequiresUserAction and update MediaTypesRequiringUserActionForPlayback to proper variable types
URL: https://github.com/apache/cordova-ios/pull/797
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org