You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/11 05:45:19 UTC

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1164: examples/nrf24l01: Change RATE_1Mbps to RATE_1MBPS

pkarashchenko commented on code in PR #1164:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1164#discussion_r869890819


##########
examples/nrf24l01_btle/nrf24l01_btle.c:
##########
@@ -219,16 +219,16 @@ int nrf24_cfg(int fd)
   int32_t txpow = DEFAULT_TXPOWER;
 
   /**************************************************************************
-   * if using RATE_1Mbps from include/nuttx/wireless/nrf24l01.h,
+   * if using RATE_1MBPS from include/nuttx/wireless/nrf24l01.h,
    * tools/checkpatch.sh report error: Mixed case identifier found.
    *
    **************************************************************************/
 
-  nrf24l01_datarate_t datarate = 0; /* RATE_1Mbps */
+  nrf24l01_datarate_t datarate = 0; /* RATE_1MBPS */

Review Comment:
   @xiaoxiang781216 do you know why `RATE_1MBPS` and `DELAY_1000US` are not used here, but `0` and `3` are used instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org