You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/04/04 15:22:50 UTC

[GitHub] [daffodil] tuxji commented on a diff in pull request #768: Daffodil 2663 pluggable charsets

tuxji commented on code in PR #768:
URL: https://github.com/apache/daffodil/pull/768#discussion_r841867026


##########
daffodil-io/src/main/scala/org/apache/daffodil/processors/charset/CharsetUtils.scala:
##########
@@ -33,11 +33,10 @@ object CharsetUtils {
    * encodings as well as the standard ones.
    */
   def getCharset(name: String): BitsCharset = {
-    val cs = DaffodilCharsetProvider.charsetForName(name)
-    cs
+    BitsCharsetDefinitionRegistry.find(name).newFactory.newInstance

Review Comment:
   OK, let's keep the Registry suffix then.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org