You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "WillAyd (via GitHub)" <gi...@apache.org> on 2024/06/17 14:30:40 UTC
[PR] refactor: Move Meson build targets to top level directory [arrow-nanoarrow]
WillAyd opened a new pull request, #530:
URL: https://github.com/apache/arrow-nanoarrow/pull/530
This makes the Meson build generate targets more closely to the CMake build. Instead of building targets in src/nanoarrow this makes it so it builds things in the build directory root
The only exception is the "nanoarrow_config.h" file which gets built to `<build_directory>/src`. The CMake installation creates a separate `generated` directory, but Meson practically limits the structure of your build folder to how the `meson.build` files are laid out in source. We could create a `generated` directory in the source if we so cared, or alternately could try to change the include to `#include <nanoarrow/nanoarrow_config.>` for consistency with all other includes, placing that generated target in the same directory as the rest of the headers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Move Meson build targets to top level directory [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #530:
URL: https://github.com/apache/arrow-nanoarrow/pull/530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Move Meson build targets to top level directory [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #530:
URL: https://github.com/apache/arrow-nanoarrow/pull/530#issuecomment-2173604691
> alternately could try to change the include to `#include <nanoarrow/nanoarrow_config.h>`
That will be the case after https://github.com/apache/arrow-nanoarrow/pull/508 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Move Meson build targets to top level directory [arrow-nanoarrow]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #530:
URL: https://github.com/apache/arrow-nanoarrow/pull/530#issuecomment-2173595705
## [Codecov](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/530?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 88.99%. Comparing base [(`41e9e71`)](https://app.codecov.io/gh/apache/arrow-nanoarrow/commit/41e9e71838669964f62d17d8547fa9bcc1c3a5af?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`ee5df26`)](https://app.codecov.io/gh/apache/arrow-nanoarrow/commit/ee5df2659757a9de1bc2f39a8aaa4e978b0f4908?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 9 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #530 +/- ##
==========================================
+ Coverage 88.92% 88.99% +0.06%
==========================================
Files 89 89
Lines 16339 16290 -49
==========================================
- Hits 14530 14497 -33
+ Misses 1809 1793 -16
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/530?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org